Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for Scan Daily, Anti-spam, and Search product cards #45067

Merged
merged 5 commits into from
Aug 20, 2020

Conversation

monsieur-z
Copy link
Contributor

Changes proposed in this Pull Request

This PR includes the final copy for the Jetpack Scan Daily, Jetpack Anti-spam, and Jetpack Search product cards.

Jetpack Complete was handled in #45009.
Security in #45035.
Backups in #45042.

Implementation notes

  • We'll use Jetpack Scan Daily instead of Jetpack Scan
  • Made sure descriptions end by the correct punctuation
  • Made sure Anti-spam is spelled correctly

Testing instructions

  • Visit the Plans page with the offer reset flow enabled
  • Show all products and plans
  • Check the copy of the product cards against the copydeck

Screenshots

Jetpack Scan Daily
Screen Shot 2020-08-20 at 11 43 32 AM

Jetpack Anti-spam
Screen Shot 2020-08-20 at 11 43 38 AM

Jetpack Search
Screen Shot 2020-08-20 at 11 43 43 AM

@matticbot
Copy link
Contributor

@monsieur-z monsieur-z changed the base branch from master to update/product-card-copy August 20, 2020 15:48
@monsieur-z monsieur-z added Jetpack [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. labels Aug 20, 2020
@matticbot
Copy link
Contributor

matticbot commented Aug 20, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~93 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main       +538 B  (+0.0%)      +93 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1536 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
purchases                 +1498 B  (+0.1%)     +234 B  (+0.1%)
plans                     +1498 B  (+0.3%)     +224 B  (+0.1%)
jetpack-connect           +1498 B  (+0.2%)     +250 B  (+0.1%)
checkout                  +1371 B  (+0.1%)     +236 B  (+0.1%)
woocommerce                +493 B  (+0.0%)      +31 B  (+0.0%)
themes                     +493 B  (+0.1%)      +29 B  (+0.0%)
theme                      +493 B  (+0.2%)      +29 B  (+0.0%)
stats                      +493 B  (+0.1%)      +28 B  (+0.0%)
signup                     +493 B  (+0.2%)      +30 B  (+0.0%)
settings-writing           +493 B  (+0.1%)      +28 B  (+0.0%)
settings-security          +493 B  (+0.2%)      +30 B  (+0.0%)
settings-performance       +493 B  (+0.2%)      +29 B  (+0.0%)
settings-jetpack           +493 B  (+0.2%)      +31 B  (+0.0%)
settings-discussion        +493 B  (+0.2%)      +31 B  (+0.0%)
settings                   +493 B  (+0.1%)      +28 B  (+0.0%)
marketing                  +493 B  (+0.1%)      +28 B  (+0.0%)
help                       +493 B  (+0.1%)      +31 B  (+0.0%)
export                     +493 B  (+0.2%)      +31 B  (+0.0%)
email                      +493 B  (+0.2%)      +31 B  (+0.0%)
domains                    +493 B  (+0.0%)      +26 B  (+0.0%)
customize                  +493 B  (+0.2%)      +31 B  (+0.1%)
activity                   +493 B  (+0.1%)      +29 B  (+0.0%)
account-close              +493 B  (+0.1%)      +31 B  (+0.0%)
accept-invite              +493 B  (+0.1%)      +30 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~556 bytes added 📈 [gzipped])

name                                                      parsed_size           gzip_size
async-load-signup-steps-plans-atomic-store                     +878 B  (+0.7%)     +176 B  (+0.5%)
async-load-signup-steps-plans                                  +878 B  (+0.4%)     +178 B  (+0.4%)
async-load-blocks-inline-help                                  +538 B  (+0.4%)      +85 B  (+0.2%)
async-load-my-sites-sidebar                                    +493 B  (+0.3%)      +31 B  (+0.1%)
async-load-my-sites-current-site-stale-cart-items-notice       +493 B  (+0.6%)      +31 B  (+0.1%)
async-load-design-blocks                                       +493 B  (+0.0%)      +25 B  (+0.0%)
async-load-design                                              +493 B  (+0.0%)      +30 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@monsieur-z monsieur-z force-pushed the update/product-card-rest-copy branch from b671903 to 89148d9 Compare August 20, 2020 16:14
@monsieur-z monsieur-z marked this pull request as ready for review August 20, 2020 16:18
@monsieur-z monsieur-z requested a review from a team August 20, 2020 16:18
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 20, 2020
Base automatically changed from update/product-card-copy to master August 20, 2020 17:44
Copy link
Contributor

@ChaosExAnima ChaosExAnima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just as a note, let's be aware that with changing the copy here we're updating it on prod for users, but I don't foresee that being an issue.

@monsieur-z monsieur-z force-pushed the update/product-card-rest-copy branch from 8a383ef to be11d84 Compare August 20, 2020 19:54
@monsieur-z monsieur-z merged commit e1e0dfd into master Aug 20, 2020
@monsieur-z monsieur-z deleted the update/product-card-rest-copy branch August 20, 2020 20:21
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 20, 2020
@a8ci18n
Copy link

a8ci18n commented Aug 20, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4248409

Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Aug 31, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants