-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copy for Scan Daily, Anti-spam, and Search product cards #45067
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~93 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~1536 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~556 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
e8539d1
to
7322873
Compare
b671903
to
89148d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just as a note, let's be aware that with changing the copy here we're updating it on prod for users, but I don't foresee that being an issue.
client/lib/products-values/get-jetpack-product-call-to-action.js
Outdated
Show resolved
Hide resolved
8a383ef
to
be11d84
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4248409 Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This PR includes the final copy for the Jetpack Scan Daily, Jetpack Anti-spam, and Jetpack Search product cards.
Jetpack Complete was handled in #45009.
Security in #45035.
Backups in #45042.
Implementation notes
Testing instructions
Screenshots
Jetpack Scan Daily
![Screen Shot 2020-08-20 at 11 43 32 AM](https://user-images.githubusercontent.com/1620183/90794212-85936a00-e2da-11ea-8d9e-e8b506189a56.png)
Jetpack Anti-spam
![Screen Shot 2020-08-20 at 11 43 38 AM](https://user-images.githubusercontent.com/1620183/90794220-89bf8780-e2da-11ea-8cb0-1c61966465c6.png)
Jetpack Search
![Screen Shot 2020-08-20 at 11 43 43 AM](https://user-images.githubusercontent.com/1620183/90794237-8deba500-e2da-11ea-80e0-d2c0eac01cb9.png)