-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dial up concierge upsell offer and include Business plan #45540
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~23 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~2 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -69,10 +69,10 @@ export default { | |||
}, | |||
conciergeUpsellDial: { | |||
//this test is used to dial down the upsell offer | |||
datestamp: '20200421', | |||
datestamp: '20200910', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know changing the datestamp effectively creates a new / restarts the experiment. If this not intended it might be better to leave this as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, but also noting here that this is a fake A/B test. We are using an A/B test only to throttle the upsell offer, and there's no analysis coming out of it. So, changing the datestamp is probably okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, that's good context to have! 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
@claudiucelfilip Noting that premium plan purchases will now always be shown a Business plan bump offer(changes went live yesterday in #44590, so would require a rebase). |
Changes proposed in this Pull Request
Per the request in pbBQWj-hz-p2#comment-997, we are dialling up the concierge upsell offers. It will now be shown to 75% of EN.
Business user will now be added to the upsell offers.
Testing instructions
Go through the signup flow at /start and purchase a:
When in the "offer" variation, you should be shown the concierge upsell. When in "noOffer" variation, you should not be shown the upsell.