Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dial up concierge upsell offer and include Business plan #45540

Merged
merged 3 commits into from
Sep 11, 2020

Conversation

claudiucelfilip
Copy link
Contributor

@claudiucelfilip claudiucelfilip commented Sep 10, 2020

Changes proposed in this Pull Request

Per the request in pbBQWj-hz-p2#comment-997, we are dialling up the concierge upsell offers. It will now be shown to 75% of EN.
Business user will now be added to the upsell offers.

Testing instructions

Go through the signup flow at /start and purchase a:

  • Personal or Premium plans to check for regression.
  • Business plan to check that it now also show the upsell.

When in the "offer" variation, you should be shown the concierge upsell. When in "noOffer" variation, you should not be shown the upsell.

@claudiucelfilip claudiucelfilip added the [Team] MarTech Used by the MarTech team. label Sep 10, 2020
@claudiucelfilip claudiucelfilip self-assigned this Sep 10, 2020
@matticbot
Copy link
Contributor

@claudiucelfilip claudiucelfilip added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 10, 2020
@claudiucelfilip claudiucelfilip changed the title Dial down concierge upsell offer and include Business plan Dial up concierge upsell offer and include Business plan Sep 10, 2020
@matticbot
Copy link
Contributor

matticbot commented Sep 10, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~23 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main       +127 B  (+0.0%)      +23 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~2 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout        +16 B  (+0.0%)       +2 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -69,10 +69,10 @@ export default {
},
conciergeUpsellDial: {
//this test is used to dial down the upsell offer
datestamp: '20200421',
datestamp: '20200910',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know changing the datestamp effectively creates a new / restarts the experiment. If this not intended it might be better to leave this as is.

Copy link
Contributor

@niranjan-uma-shankar niranjan-uma-shankar Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, but also noting here that this is a fake A/B test. We are using an A/B test only to throttle the upsell offer, and there's no analysis coming out of it. So, changing the datestamp is probably okay.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that's good context to have! 🙂

Copy link
Contributor

@niranjan-uma-shankar niranjan-uma-shankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@niranjan-uma-shankar
Copy link
Contributor

@claudiucelfilip Noting that premium plan purchases will now always be shown a Business plan bump offer(changes went live yesterday in #44590, so would require a rebase).

@claudiucelfilip claudiucelfilip merged commit 33b3ff5 into master Sep 11, 2020
@claudiucelfilip claudiucelfilip deleted the update/adjust-checkout-qs-upsell branch September 11, 2020 13:09
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] MarTech Used by the MarTech team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants