-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/loading state to unified nav #45831
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~150 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
I'm going to amend this to follow a reducer/state pattern more closely aligned with |
adbc084
to
45e0d58
Compare
This is temporary whislt we decide on ideal loading state
This enables higher fidelity unit testing as we like to assert on the keyed nature of the reducer.
0173e2a
to
be34f6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dave!
Tests pass and the UX is better than having no visual indicator 👍 !
Changes proposed in this Pull Request
<Spinner />
.Testing instructions
For debugging purposes you can force this UI state to appear by opening browser dev tools and typing
state.adminMenu.requesting.isRequesting = true
.Fixes #45830