Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/loading state to unified nav #45831

Merged
merged 7 commits into from
Sep 24, 2020
Merged

Add/loading state to unified nav #45831

merged 7 commits into from
Sep 24, 2020

Commits on Sep 23, 2020

  1. Update state shape to allow for interogation of admin menu request st… 

    …atus
    @getdave
    getdave committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    8fdc663 View commit details
    Browse the repository at this point in the history

  2. Update sidebar to use loading spinner 

    This is temporary whislt we decide on ideal loading state
    @getdave
    getdave committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    49d8886 View commit details
    Browse the repository at this point in the history

  3. Add loading UI

    @getdave
    getdave committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    25b6d7b View commit details
    Browse the repository at this point in the history

  4. Update tests to match

    @getdave
    getdave committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    f81ed06 View commit details
    Browse the repository at this point in the history

  5. Simplify state for requesting status

    @getdave
    getdave committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    c3f47e4 View commit details
    Browse the repository at this point in the history

  6. Update menus reducer export to be keyed 

    This enables higher fidelity unit testing as we like to assert on the keyed nature of the reducer.
    @getdave
    getdave committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    a281972 View commit details
    Browse the repository at this point in the history

  7. Refactor reducer tests to test each reducer independently.

    @getdave
    getdave committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    be34f6e View commit details
    Browse the repository at this point in the history