-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get In Progress Rewind API Entry Details #47071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WordPress Desktop CI Failure for job "wp-desktop-mac".
@elliottprogrammer please inspect this job's build steps for breaking changes at this link. For temporal failures, you may try to "Rerun Workflow from Failed".
Please also ensure this branch is rebased off latest Calypso.
wp-desktop ci passing, closing review
getInProgressRewindEntryDetails( state, siteId, rewindId ) | ||
); | ||
|
||
console.log( inProgressRewindEntryDetails ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just temporary, of course. Just for testing.
84674fa
to
bbf96a8
Compare
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~373 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~221 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Closing as I'm going through the list of PRs requiring review :) |
Changes proposed in this Pull Request
This PR allows access to 2 new properties from the rewind API (
message
andentry
) when the rewind status is "active" and "running".Implementation notes:
message
andcurrent_entry
response fields from the rewind API intoschema.js
andapi-transformer,js
to be schema parsed and camel-cased.getInProgressRewindEntryDetails()
Testing instructions
wordpress.com
andpublic-api.wordpress.com
to your sandbox IP (in your hosts file).http://calypso.localhost:3000/backup/:site
Select a date and click to "Restore to this point"getInProgressRewindEntryDetails()
selector. It will be an object with properties:message
andentry
.Important note:
the
entry
response will always be "Unknown
" for now, just until an upcoming VaultPress patch is in place coming soon.But the message response should return values such as,
Starting
,Parsing Manifest
,Streaming files
,Importing SQL dump
, andRenaming tables
.Fixes #