-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details to restore progress screen #47153
Conversation
@keoshi, as soon as the restore starts, we're seeing no message or entry for a couple of seconds (see capture below). How do you feel about this? Do we need to implement a loading state? |
@monsieur-z Thanks for the heads-up on this, Kev! Could we add some placeholders while the text isn't populated with real information? What about these two snippets, one for the top and one the for bottom portions:
I don't love the |
Maybe |
Both sound more “tech-y” than I'd like, but yeah, |
Maybe |
@ChaosExAnima Haha! I like |
@keoshi , @ChaosExAnima , @monsieur-z , One thing to note here to go with your discussion above. The rewind API will be returning 2 separate fields: They are
In this implementation, and in the Figma mockups we're not utilizing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Looking forward to seeing it once the api is returning the right entry
values (verses "Unknown"). Works as expected so far, code looks good!
LGTM! 👍
We display |
Oh!! Oops! My bad.. 🤦 I didn't notice that! Disregard my previous comment then. 😂 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~430 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~221 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Love it!! I think it's a great improvement @monsieur-z! 👍 @keoshi , what do you think? |
That looks pretty dang cool! Thanks for making those adjustments @monsieur-z — ship it. |
Awesome work folks. It looks really really nice! |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5127361 Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This PR adds more details to the restore progress screen, so that users have a better understanding of what's happening in real-time. See captures below.
Implementation notes
Currently restoring: [entry]
).Note: the back-end returns Unknown for the entry while it's being finalized. This should never be the case once done.
Testing instructions
public-api.wordpress.com
to itScreenshots
Mockups
Before
![98129356-077d4300-1e87-11eb-9145-7d4331aa2fab](https://user-images.githubusercontent.com/1620183/98265383-061b4b80-1f57-11eb-9915-a751d8567d53.png)
After
![98129447-2085f400-1e87-11eb-9c46-36a3f54f48af](https://user-images.githubusercontent.com/1620183/98265394-09163c00-1f57-11eb-8d96-8e5046889888.png)
Implementation