-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Custom Description for Rollback Fixer #48738
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~44 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Tagging Voyager in too, although this is a small change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed in wpcom\public_html\wp-content\lib\vaultpress\threat\class-threat.php
that we're translating to real dates for the API, so simply displaying the target here is ok without the need for more parsing. Fine from my end.
I should note that, other than the date format, everything showed up correctly for me. I'm sure our customers will appreciate this once it's merged 👍 |
No, it's a straight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's fixable in the back end without a ton of effort, I don't see any reason to hold up this PR. At worst, the date format will be incorrect for a bit. Approving for my part, but what do y'all think?
Yes; it's better than the default fixer message and the date change should be able to be just swapping to use |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5428521 Hi @jwidavid, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
Example: Jetpack Scan will rollback the affected file to the version from January 8, 2021, 3:40 am.
Testing instructions
Jetpack Scan will rollback the affected file to the version from <date-and-time>.