-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Billing: Update ChangePaymentMethod to use PaymentMethodSelector #49058
Billing: Update ChangePaymentMethod to use PaymentMethodSelector #49058
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~30 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~49 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Works as described in both the site level and account level contexts. |
It's derived from the purchase and we're already passing in the purchase.
06d0cbd
to
c0b66ed
Compare
Rebased after some changes to notifications landed. Testing it still works as far as I can tell. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5487305 Thank you @sirbrillig for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This abstracts the payment method list and assignment code from
ChangePaymentMethod
into its own component calledPaymentMethodSelector
. The primary purpose of this is to enable reusing that component in other payment method forms likeAddNewPaymentMethod
.Part of #48966
Depends on #49057
Testing instructions