-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Billing: Replace PaymentMethodForm
#48966
Comments
#49059 Will convert the account-level After that is merged, I'd like to see if it's possible to convert the site-level Finally three more things will need to be done: We'll need to convert We'll need to convert the Finally we'll be able to remove |
PaymentMethodForm
with ChangePaymentMethodList
PaymentMethodForm
#49897 converts the "add payment method" site-level form. That leaves the WooCommerce shipping labels system as the only place still using |
When #48421 is closed, we can removed |
Recently we've modified
ChangePaymentMethod
to replacePaymentMethodForm
(which just displays a set of credit card fields) withChangePaymentMethodList
that uses thecomposite-checkout
package to allow choosing between multiple payment methods (existing cards, new cards, or PayPal).The
AddPaymentMethod
component and bothAddNewPaymentMethod
components (one for site-level and one for account-level), as well as the WooCommerceAddCardDialog
(which may not be used...), all used to add a payment method without an attached subscription, still usePaymentMethodForm
. We could modify these to useChangePaymentMethodList
as well, configured to hide existing cards and PayPal (since we do not support unattached PayPal billing agreements at the moment and you cannot "add" an existing card).The advantage of using a single component is that we will be more easily able to update it with future improvements. Notably, we'd like to add the ability to choose if a payment method should be assigned to one or multiple subscriptions (currently the components mentioned above assign the new payment method to all subscriptions).
The text was updated successfully, but these errors were encountered: