Initial work towards new email home page #50790
Conversation
daledupreez
added
the
Professional Email
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~5 bytes added 📈 [gzipped]) Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~11415 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~196 bytes removed 📉 [gzipped]) React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
| <img | ||
| className="email-management-list-item__header-icon email-forward" | ||
| src={ emailForwardingIcon } | ||
| alt={ translate( 'Email Forwarding icon' ) } |
There was a problem hiding this comment.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 31 times:
translate( 'Email Forwarding' ) ES Score: 7
| { this.renderEmails() } | ||
| { this.canUserAddEmailAccounts( domain ) && ( | ||
| <VerticalNavItem path="#" onClick={ wrappedAddEmailHandler }> | ||
| { translate( 'Add new mailbox' ) } |
There was a problem hiding this comment.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 17 times:
translate( 'Add New Mailboxes' ) ES Score: 8
| const numberOfMailboxes = this.getMailboxCount( domain ); | ||
| const mailboxCountText = numberOfMailboxes | ||
| ? '- ' + | ||
| translate( '%(numberOfMailboxes)d mailbox', '%(numberOfMailboxes)d mailboxes', { |
There was a problem hiding this comment.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 8 times:
translate( 'You have %(numberOfMailboxes)d unused mailbox', 'You have %(numberOfMailboxes)d unused mailboxes' ) ES Score: 7
| @@ -0,0 +1,3 @@ | |||
| export function getTitanMailOwnerId( domain ) { | |||
| return domain?.titanMailSubscription?.ownedByUserId; | |||
| } | |||
There was a problem hiding this comment.
Not related to your pull request, but it would be great to follow a consistent naming for this product in our code: sometimes we refers to it as TitanMail and sometimes as just Titan (even in this client/lib/titan folder).
| <React.Fragment> | ||
| <SectionHeader label={ translate( 'Active Email Plans' ) } /> | ||
| <div className="email-management-list__active-emails">{ activeEmailItems }</div> | ||
| </React.Fragment> |
There was a problem hiding this comment.
Note you can also use the <>[...]</>` shorter notation.
There was a problem hiding this comment.
TIL! I'll take that on today.
hambai
force-pushed
the
try/new-email-nav-structure
branch
from
5151cb3
to
ddfa7ed
Compare
hambai
force-pushed
the
try/new-email-nav-structure
branch
from
ddfa7ed
to
c0d7f85
Compare
|
Closing this in favour of #51452. |
Changes proposed in this Pull Request
Testing instructions
To enable the new UI, visit
/email/[your.site]?flags=email/centralized-home