New emails home screen #51452

hambai · 2021-03-26T16:08:16Z

This is an initial PR to create the new/updated email management screens. @hambai built most of the infrastructure, but we delayed some work to wait for updated designs. The code is heavily based on #50790 but in the end it was easier to start clean and manually move stuff from the old PR.

The PR has been updated to fold in the updated designs in pcDL0W-al-p2, though we still have a ways to go before we get all the elements in.

Changes proposed in this Pull Request

Add the new emails home screen component
Introduce separate components for email list, email status, mailbox list, subscription management, etc
Wire in the new general-purpose REST API for email accounts (implemented in D60197-code) -- more on this in the TODO/Known Issues section

Screenshots

The email list:

Email forwards:

Note that the list of email forwards also needs D60279-code to land.

WordPress.com Email:

G Suite:

Known Issues and TODOs

This PR is mostly intended to land the core functionality behind the email/centralized-home feature flag so we can iterate with much smaller patches. It also means we can get some clear feedback from design on how to prioritise remaining tasks.

We still have the following items outstanding:

Verify that the implementation matches the mobile designs
Show warnings for the email subscription; it should be similar to how we render domain warnings in the domain management screen
Add the "no domains" component
Show the "needs action" state in the email list
Show the target address and verification button for email forwarding mailboxes
Implement the mailbox action menu and actions
Add tracking for all the things
Show an empty mailbox list when there are no mailboxes set up
Add loading mailboxes placeholder component
Move the account/mailbox loading into Redux and the global state
D60334-code needs to land on the back end to identify G Suite accounts (we currently show Google Workspace due to this bug)

Testing instructions

Apply D60197-code on your sandbox and ensure that you're routing requests to your sandbox.
- If that patch has already been deployed (which should happen early on 2021-04-19), apply D60279-code to your sandbox to add email forwarding addresses.
Go to http://calypso.localhost:3000/email?flags=email/centralized-home or to /email?flags=email/centralized-home on the calypso.live branch
Verify general site email page works when there is only one domain for the selected site (i.e. /email/siteSlug.tld)
Verify that you can see all the active email services for the selected site when you have multiple domains with email services
Verify that you see a list of domains that don't have email under the "Other domains" section of the page
- If you happen to have domains that don't currently allow email purchases (which are mostly triggered due to the domain being expired or due to it being owned by another user), ensure that the "Add Email" button is not displayed.
Verify that you can navigate to each service/domain combination, and on each of those pages verify the following:
- We show an appropriate title (with the exception of G Suite, which is due to a bug addressed by D60334-code)
- We show the correct logo in the header, and offer subscription management options for WordPress.com Email, G Suite, and Google Workspace, but don't offer the subscription toggles for email forwarding and Titan purchases from the MVP period. (This last may not be easy to test/verify -- we can defer that.)
- For all providers, we show the list of mailboxes/forwards _(with the possible exception of email forwards, which depend on D60279-code)
- For all providers, we show a menu item to add a new mailbox, and clicking on the item takes you to the correct page
- For WordPress.com Email, G Suite, and Google Workspace, we show a "Manage all mailboxes" item with an external link indicator, and clicking on it takes you to the correct admin UI. If you're running via calypso.localhost, the WordPress.com Email link should not be internal, as we show the iframed control panel in that case.
- For WordPress.com Email, G Suite, and Google Workspace, we show a "Billing and payment settings" link. Confirm that clicking on the link takes you to the subscription management page.

In general, please keep an eye out for any weirdness/bugs. We'll likely fix them in follow-up PRs, but it would be good to catch anything like this. (I already tripped over an issue with the VerticalNavItem placeholder display that I fixed in #52028!)

matticbot · 2021-03-26T16:08:17Z

Test live: https://calypso.live/?branch=new/email-home-screen

matticbot · 2021-03-26T16:15:29Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~280 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                 +1015 B  (+0.1%)     +280 B  (+0.1%)
entry-login                 +691 B  (+0.1%)     +175 B  (+0.1%)
entry-gutenboarding         +691 B  (+0.0%)     +175 B  (+0.0%)
entry-domains-landing       +691 B  (+0.1%)     +175 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1754 bytes added 📈 [gzipped])

name                      parsed_size            gzip_size
email                        +58305 B  (+13.7%)   +14887 B  (+12.2%)
domains                       +1389 B   (+0.1%)    +2158 B   (+0.7%)
checkout                       +199 B   (+0.0%)     +979 B   (+0.3%)
signup                         +183 B   (+0.1%)    +1009 B   (+1.7%)
plans                          -112 B   (-0.0%)     -707 B   (-0.4%)
zoninator                       +71 B   (+0.0%)      +25 B   (+0.0%)
wp-super-cache                  +71 B   (+0.0%)      +25 B   (+0.0%)
woocommerce-installation        +71 B   (+0.0%)      +25 B   (+0.1%)
woocommerce                     +71 B   (+0.0%)      +25 B   (+0.0%)
themes                          +71 B   (+0.0%)      +25 B   (+0.0%)
theme                           +71 B   (+0.0%)      +25 B   (+0.0%)
stats                           +71 B   (+0.0%)      +25 B   (+0.0%)
sites                           +71 B   (+0.1%)      +25 B   (+0.1%)
site-purchases                  +71 B   (+0.0%)      +25 B   (+0.0%)
settings-writing                +71 B   (+0.0%)      +25 B   (+0.0%)
settings-security               +71 B   (+0.0%)      +25 B   (+0.0%)
settings-performance            +71 B   (+0.0%)      +25 B   (+0.0%)
settings-jetpack                +71 B   (+0.0%)      +25 B   (+0.0%)
settings-discussion             +71 B   (+0.0%)      +25 B   (+0.0%)
settings                        +71 B   (+0.0%)      +25 B   (+0.0%)
sensei                          +71 B   (+0.1%)      +25 B   (+0.1%)
scan                            +71 B   (+0.0%)      +25 B   (+0.0%)
purchases                       +71 B   (+0.0%)      +25 B   (+0.0%)
preview                         +71 B   (+0.1%)      +25 B   (+0.1%)
posts-custom                    +71 B   (+0.0%)      +25 B   (+0.0%)
posts                           +71 B   (+0.0%)      +25 B   (+0.0%)
plugins                         +71 B   (+0.0%)      +25 B   (+0.0%)
people                          +71 B   (+0.0%)      +31 B   (+0.0%)
pages                           +71 B   (+0.0%)      +25 B   (+0.0%)
migrate                         +71 B   (+0.0%)      +25 B   (+0.1%)
media                           +71 B   (+0.0%)      +25 B   (+0.0%)
marketing                       +71 B   (+0.0%)      +25 B   (+0.0%)
jetpack-search                  +71 B   (+0.0%)      +25 B   (+0.0%)
jetpack-connect                 +71 B   (+0.0%)      -21 B   (-0.0%)
jetpack-cloud-settings          +71 B   (+0.0%)      +25 B   (+0.0%)
jetpack-cloud-pricing           +71 B   (+0.0%)      -59 B   (-0.1%)
jetpack-cloud                   +71 B   (+0.1%)      +25 B   (+0.1%)
import                          +71 B   (+0.0%)      +25 B   (+0.0%)
hosting                         +71 B   (+0.0%)      +25 B   (+0.0%)
home                            +71 B   (+0.0%)      +25 B   (+0.0%)
hello-dolly                     +71 B   (+0.1%)      +25 B   (+0.1%)
gutenberg-editor                +71 B   (+0.0%)      +36 B   (+0.0%)
google-my-business              +71 B   (+0.0%)      +25 B   (+0.0%)
export                          +71 B   (+0.0%)      +25 B   (+0.1%)
earn                            +71 B   (+0.0%)      +25 B   (+0.0%)
customize                       +71 B   (+0.0%)      +25 B   (+0.1%)
concierge                       +71 B   (+0.0%)      +25 B   (+0.0%)
comments                        +71 B   (+0.0%)      +25 B   (+0.0%)
backup                          +71 B   (+0.0%)      +25 B   (+0.0%)
activity                        +71 B   (+0.0%)      +25 B   (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

client/my-sites/email/email-management/home/email-plan-view.jsx

client/my-sites/email/email-management/home/email-type-icon.jsx

client/my-sites/email/email-management/home/email-plan-mailboxes-list.jsx

stephanethomas

I like how clear the logic is, and how each component are designed (except maybe the EmailPlanView which is doing too many things). That's a lot of code so I left several comments but most of them are minor.

Not for this pull request but we should probably make sure that all pages of the domain and email management sections have the same width, as right now it's not consistent. We could also order the lists of domains alphabetically on the new Email Homepage.

client/my-sites/email/email-management/home/email-plan-view.jsx

client/my-sites/email/email-management/home/email-list-active.jsx

stephanethomas · 2021-03-30T11:56:04Z

client/lib/domains/can-add-email-to-domain.js

+	}
+
+	return true;
+}


Aren't we performing eligibility checks server-side now? @daledupreez or @olaseni may be able to provide more details.

client/lib/domains/email-forwarding/has-email-forwards.js

client/my-sites/email/email-management/email-home.jsx

client/my-sites/email/email-management/home/email-plan-mailboxes-list.jsx

client/my-sites/email/email-management/home/email-plan-subscription.jsx

client/my-sites/email/email-management/home/email-plan-view.jsx

stephanethomas · 2021-03-30T13:00:34Z

client/my-sites/email/email-management/home/email-plan-view.jsx

+			</React.Fragment>
+		);
+	}
+}


I would recommend refactoring this component. At first I thought it would handle all types of email accounts. Then I started reading it, and found that it actually contains lots of logic that is specific to Titan. And finally, I've realized that it's indeed for G Suite and email forwards when I reached the part where we connect it to the Redux state tree. We should really separate responsibilities, extract the code that retrieves the list of Titan mailboxes in a Query component, moves the normalization logic in another component ...

The code is in there temporary - I just didn't want to add all the boilerplate code in one single PR as that would make the PR even bigger. This is actually on my list of next tasks - "Move the Titan mailboxes loading into global state"

Gotcha. I've mentioned it in the server patch but I believe we could simplify this code a lot if data normalization happened on the server, and if we used one API endpoint to retrieve all the email accounts (may they be for Titan or Google Workspace).

Actually there is a stub for this called QueryEmailAccounts and related redux stuff in client/state/email-accounts but it would require a lot more changed to actually make this work so I decided on making this PR work instead and leave the refactoring for later. It would definitely make the code simpler but it's just too big to include in this PR.

client/my-sites/email/email-management/home/email-plan.jsx

daledupreez · 2021-04-19T08:18:02Z

@saygunnyc, when you get online today, I would really appreciate your eyes on the changes here. We're not all the way there yet in terms of implementation, but this gets the bulk of the infrastructure into place. (There are plenty of TODOs to take on!)

In particular, there is one smaller item where I'd like you to weigh in, and then a much broader one as well.

Vertical spacing

The first area that would be good to align on is vertical spacing. The designs have all the cards in lists with a height of 80px. In the main home page, I think that makes sense, as we have a lot going on in each row, including buttons and/or logos, so the space is likely necessary. On the domain/account-specific page, the default spacing for cards has the height way less at around 56px, as all the rows only contain text. In this iteration, I've increased the padding to 24px above and below the text, but this only brings the height for these rows to 72px. LMK if you think we should increase the padding to 28px either side to keep the element spacing the same vs the internal spacing.

Staging the remaining work

While our goal is clearly to ship all the improvements to users, I also don't want to defer getting all the improvements into place before we launch the new pages. From my side, I think the following items are absolute must-haves. Please weigh in with any not on my list that you think we need for launch.

Proposed must-haves

Mobile support - we haven't worked on this yet
Show warnings/notices for each email subscription; it should be similar to how we render domain warnings in the domain management screen
Implement the "no domains" component
Show the "needs action" state in the email list
Show the target address and verification button for email forwarding mailboxes
Add tracking for all clicks and navigation
Show an empty mailbox list when there are no mailboxes set up
Add loading mailboxes placeholder component

Proposed non-blocking items

Implement the mailbox action menu and actions
Move the account/mailbox loading into Redux and the global state
Update some email-related pages to navigate "Back" to the correct page instead of going to domain management by default (though there are some flows where that is appropriate, like clicking "Add Email" on the domain listing screen or managing email from the domains screen).
Update some email-related pages to use the new email header instead the domain header

saygunnyc · 2021-04-19T20:17:15Z

Hey Dale,
Thank you for sharing this!

Vertical spacing

Yes, let's have all be consistent. Same height for both email products and mailboxes. Mailboxes will also have a lot going on soon with the addition of the overflow menu, nudges, and CTAs, so I'd say it's better to do the change now rather than later.

Staging the remaining work

At a high level, I would say we shouldn't be removing any functionalities or links that users can reach today. An example of that would be having links to Gmail, Slides, etc. on Google Workspace as well as Inbox, Calendar, etc. on Titan. I'm open to staging what makes the most sense for the rest but in a frame where we're not creating UX issues or taking away something we provided earlier to the user.

One another question,

Show an empty mailbox list when there are no mailboxes set up

Do we have a case like this? If yes, then we should direct the user to take action. What's the required action for the user in this case? How does the empty mailbox list look like?

* extract the email type icon * fixed the active email list styling * fixed the active email mailbox count string

client/my-sites/email/email-management/home/email-plan.jsx

stephanethomas

I've tested it, and everything seems to work fine - apart from the limitations already mentioned in the description of this pull request. I've found the following issues though:

We don't display any Finish Setup notice for Google Workspace and G Suite
We don't display any Finish Setup button for Google Workspace and G Suite
We don't display any You have n unused mailbox message for Titan
The Back button always redirects to the general Email page even if coming from the Domain Settings page

All of this, plus the suggestions I've made in some comments, can of course be addressed in future iterations. It would be good to address issue #1 and #2 asap though.

client/lib/domains/email-forwarding/get-email-forwards-count.js

stephanethomas · 2021-04-21T10:02:55Z

client/lib/emails/is-email-user-admin.js

+
+export function isEmailUserAdmin( emailUser ) {
+	return EMAIL_USER_ROLE_ADMIN === emailUser?.role;
+}


I'm concerned that we're introducing yet another name for something we usually call a user for G Suite, and mailbox for Titan. We should really agree on a term.

client/lib/gsuite/get-google-product-slug.js

stephanethomas · 2021-04-21T10:06:08Z

client/lib/wpcom-undocumented/lib/undocumented.js

@@ -759,6 +759,18 @@ Undocumented.prototype.validateGoogleAppsContactInformation = function (
 	return result.then?.( camelCaseKeys );
 };

+Undocumented.prototype.getEmailAccountsForSiteAndDomain = function ( siteId, domain, fn ) {


Shouldn't the name reflect the fact that the list of accounts retrieved will also contain the list of mailboxes? What will happen when we start using this API endpoint to only retrieve accounts (and not mailboxes)?

My thinking here is that I want this to be replaced/updated pretty soon.

In terms of naming, does it make sense to call this getMailboxesForSiteAndDomain()? Or should we call it something else?

stephanethomas · 2021-04-21T11:17:48Z

client/my-sites/email/email-management/email-home.jsx

+		return this.renderContentWithHeader(
+			<>
+				<SectionHeader className="email-home__section-placeholder is-placeholder" />
+				<Card className="email-home__content-placeholder is-placeholder" />


Do we really need to define the email-home__section-placeholder and email-home__content-placeholder classes? There are never used anywhere.

I don't think I added these specific classes, but this is a "feature" of the linter -- all initial class names need to include an acceptable prefix.

I understand that the linter may complain if a class name doesn't have the right prefix. Do you mean it also added those class names itself (assuming you used it with the --fix argument)?

No, the issue is that if you try to add just a different classname, like className="is-placeholder", the linter won't accept that. One workaround is to then use className="some_compliant_prefix__something is-placeholder". I am not saying that it's a good approach, but it's one that is linter-compliant. :-/

Got it, thanks for the clarification. There is not much we can do indeed 😞.

client/my-sites/email/email-management/home/email-plan.jsx

client/my-sites/email/email-management/home/email-plan-subscription.jsx

stephanethomas · 2021-04-21T11:47:35Z

client/my-sites/email/email-management/home/utils.js

+	return '';
+}
+
+export function resolveEmailPlanStatus( domain ) {


I'm not a big fan of that function name as it doesn't provide any clue regarding the type of data returned. Maybe it does too much? Looking at how it is used, maybe we could have two distinct functions - one that returns if the status is ok or not, and another one that renders this status:

export function renderEmailPlanStatus( domain ) { let icon = 'check_circle'; let text = translate( 'Active' ); if ( hasPendingGSuiteUsers( domain ) ) { icon = 'info'; text = translate( 'Action required' ); } return ( <span className="email-plan__status"> <MaterialIcon icon={ icon } /> { text } </span> ); }

stephanethomas · 2021-04-21T11:49:24Z

client/my-sites/email/email-management/style.scss

+		width: 150px;
+		height: 28px;
+	}
+}


All of this should most probably be moved to a new stylesheet in the home subfolder.

a8ci18n · 2021-04-21T14:44:30Z

client/my-sites/email/email-management/home/email-plan.jsx

+			return translate( 'Email settings' );
+		}
+
+		return translate( 'Email forwarding settings' );


ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 32 times:
translate( 'Email Forwarding' ) ES Score: 6

a8ci18n · 2021-04-21T14:44:31Z

client/my-sites/email/email-management/home/email-plan.jsx

+		const managePurchaseUrl = getManagePurchaseUrlFor( selectedSite.slug, purchase.id );
+		return (
+			<VerticalNavItem path={ managePurchaseUrl }>
+				{ translate( 'Billing and payment settings' ) }


ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 18 times:
translate( 'Update your billing and payment settings' ) ES Score: 7

a8ci18n · 2021-04-21T14:44:31Z

client/my-sites/email/email-management/home/email-plan.jsx

+				<div className="email-plan__actions">
+					<VerticalNav>
+						<VerticalNavItem { ...addMailboxProps }>
+							{ translate( 'Add new mailbox' ) }


ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 17 times:
translate( 'Add New Mailboxes' ) ES Score: 8

saygunnyc · 2021-04-21T14:52:38Z

How are we planning to resolve these cases if not within the interface?
1.We don't display any Finish Setup notice for Google Workspace and G Suite
2.We don't display any Finish Setup button for Google Workspace and G Suite
3.We don't display any You have n unused mailbox message for Titan

Can you expand this a little, so I understand better.
4.The Back button always redirects to the general Email page even if coming from the Domain Settings page

stephanethomas · 2021-04-21T17:39:51Z

How are we planning to resolve these cases if not within the interface?

I'm not sure to understand your question @saygunnyc 🙂. I personally think those issues should be addressed prior to launching this new Emails page to users. They don't prevent us from merging this pull request though since this page is hidden behind a feature flag.

Can you expand this a little, so I understand better.

Sure. If I'm on the new Emails page and click a Google Workspace account I'm presented with the Google Workspace settings page. If I click the Back button in the section header, I'm redirected to the Emails page, all is fine. Now if go to the Domains page, click the domain of that Google Workspace account, click the Manage your email accounts option, I'm again presented with the same Google Workspace settings page than earlier. However, if I click the Back button I'm taken to the Emails page while I would have expected to go back to the Domain Settings page (like the back button of the browser).

saygunnyc · 2021-04-21T17:50:34Z

Yes, all make sense to me now! Thank you, @stephanethomas for clarifying!

a8ci18n · 2021-04-21T18:16:46Z

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5748853

Thank you @hambai for including a screenshot in the description! This is really helpful for our translators.

tyxla · 2021-04-23T13:09:26Z

client/my-sites/email/email-management/home/email-plan.jsx

+
+	state = {
+		isLoadingEmailAccounts: false,
+		errorLoadingEmailAccounts: false,


Seems like we set this state property but we never use it. Maybe it can be removed?

Thanks Marin! I will remove it in #52815.

Thanks, @stephanethomas 🙌

a8ci18n · 2021-04-30T15:28:23Z

Translation for this Pull Request has now been finished.

hambai self-assigned this Mar 26, 2021

a8ci18n reviewed Mar 26, 2021

View reviewed changes

client/my-sites/email/email-management/home/email-plan-view.jsx Outdated Show resolved Hide resolved

a8ci18n reviewed Mar 26, 2021

View reviewed changes

client/my-sites/email/email-management/home/email-type-icon.jsx Show resolved Hide resolved

a8ci18n reviewed Mar 28, 2021

View reviewed changes

client/my-sites/email/email-management/home/email-plan-mailboxes-list.jsx Show resolved Hide resolved

hambai added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 29, 2021

hambai marked this pull request as ready for review March 29, 2021 13:45

hambai requested a review from a team as a code owner March 29, 2021 13:45

stephanethomas requested changes Mar 30, 2021

View reviewed changes

saygunnyc added the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Apr 2, 2021

github-actions bot added the [Status] Design Input Requested Label automatically added to PRs where design feedback is requested label Apr 2, 2021

saygunnyc removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Design Input Requested Label automatically added to PRs where design feedback is requested labels Apr 2, 2021

daledupreez assigned daledupreez and unassigned hambai Apr 16, 2021

daledupreez force-pushed the new/email-home-screen branch from 8924550 to e6b2911 Compare April 16, 2021 12:13

a8ci18n reviewed Apr 16, 2021

View reviewed changes

client/my-sites/email/email-management/home/email-plan.jsx Show resolved Hide resolved

a8ci18n reviewed Apr 16, 2021

View reviewed changes

client/my-sites/email/email-management/home/email-plan.jsx Show resolved Hide resolved

a8ci18n reviewed Apr 16, 2021

View reviewed changes

client/my-sites/email/email-management/home/email-plan.jsx Show resolved Hide resolved

daledupreez added the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Apr 17, 2021

github-actions bot added the [Status] Design Input Requested Label automatically added to PRs where design feedback is requested label Apr 17, 2021

daledupreez requested a review from a team April 17, 2021 19:59

daledupreez mentioned this pull request Apr 20, 2021

Add mailbox list placeholder in new email list #52075

Merged

hambai added 3 commits April 20, 2021 09:23

* initial structure of the new email management home

283e65e

* add plan view

f26182e

* extract the email type icon * fixed the active email list styling * fixed the active email mailbox count string

* fix the inactive list button placement

0485558

daledupreez added 4 commits April 20, 2021 09:23

Remove code to fetch provider-specific email data

78c4eee

Enable email/centralized-home feature flag in development

e774c39

Use correct case for isPlaceholder prop

640c392

Increase padding for rows on subscription/domain screen

66c37aa

daledupreez force-pushed the new/email-home-screen branch from 9bd4946 to 66c37aa Compare April 20, 2021 07:28

daledupreez mentioned this pull request Apr 20, 2021

Initial work towards new email home page #50790

Closed

a8ci18n reviewed Apr 20, 2021

View reviewed changes

client/my-sites/email/email-management/home/email-plan.jsx Show resolved Hide resolved

a8ci18n reviewed Apr 20, 2021

View reviewed changes

client/my-sites/email/email-management/home/email-plan.jsx Show resolved Hide resolved

a8ci18n reviewed Apr 20, 2021

View reviewed changes

client/my-sites/email/email-management/home/email-plan.jsx Show resolved Hide resolved

stephanethomas approved these changes Apr 21, 2021

View reviewed changes

daledupreez added 6 commits April 21, 2021 16:12

Add documentation RE domain arguments

a5e18c7

Rename getGoogleProductSlug() to getGSuiteProductSlug()

f74ae2c

Remove unused class

8634f6a

Rename loadedEmailAccounts to hasLoadedEmailAccounts

9dfa276

Minor variable rename

e0bd6f4

Simplify internal function name

2528ccd

a8ci18n reviewed Apr 21, 2021

View reviewed changes

daledupreez merged commit 09e109d into trunk Apr 21, 2021

daledupreez deleted the new/email-home-screen branch April 21, 2021 17:56

tyxla reviewed Apr 23, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New emails home screen #51452

New emails home screen #51452

hambai commented Mar 26, 2021 •

edited by daledupreez

matticbot commented Mar 26, 2021

matticbot commented Mar 26, 2021 •

edited

stephanethomas left a comment

stephanethomas Mar 30, 2021

stephanethomas Mar 30, 2021

hambai Mar 31, 2021

stephanethomas Mar 31, 2021 •

edited

hambai Mar 31, 2021

daledupreez commented Apr 19, 2021

saygunnyc commented Apr 19, 2021

stephanethomas left a comment

stephanethomas Apr 21, 2021

stephanethomas Apr 21, 2021

daledupreez Apr 21, 2021

stephanethomas Apr 21, 2021

daledupreez Apr 21, 2021 •

edited

stephanethomas Apr 21, 2021

daledupreez Apr 21, 2021

stephanethomas Apr 22, 2021

stephanethomas Apr 21, 2021

stephanethomas Apr 21, 2021

daledupreez Apr 21, 2021

a8ci18n Apr 21, 2021

a8ci18n Apr 21, 2021

a8ci18n Apr 21, 2021

saygunnyc commented Apr 21, 2021

stephanethomas commented Apr 21, 2021

saygunnyc commented Apr 21, 2021

a8ci18n commented Apr 21, 2021

tyxla Apr 23, 2021

stephanethomas May 13, 2021

tyxla May 13, 2021

a8ci18n commented Apr 30, 2021

New emails home screen #51452

New emails home screen #51452

Conversation

hambai commented Mar 26, 2021 • edited by daledupreez

Changes proposed in this Pull Request

Screenshots

Known Issues and TODOs

Testing instructions

matticbot commented Mar 26, 2021

matticbot commented Mar 26, 2021 • edited

stephanethomas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stephanethomas Mar 31, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daledupreez commented Apr 19, 2021

Vertical spacing

Staging the remaining work

Proposed must-haves

Proposed non-blocking items

saygunnyc commented Apr 19, 2021

stephanethomas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daledupreez Apr 21, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saygunnyc commented Apr 21, 2021

stephanethomas commented Apr 21, 2021

saygunnyc commented Apr 21, 2021

a8ci18n commented Apr 21, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

a8ci18n commented Apr 30, 2021

hambai commented Mar 26, 2021 •

edited by daledupreez

matticbot commented Mar 26, 2021 •

edited

stephanethomas Mar 31, 2021 •

edited

daledupreez Apr 21, 2021 •

edited