Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract email features into separate file and clean up Titan feature flag code #51298

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

daledupreez
Copy link
Contributor

Changes proposed in this Pull Request

  • This PR extracts the feature lists for Titan, Google, and Email Forwarding into a separate to facilitate re-use for upcoming updates to the email comparison page.

Testing instructions

  • Using a local build or a live branch, try to add email to a domain you already own. Verify that the features for all three options appear.

@daledupreez daledupreez requested a review from a team March 23, 2021 08:39
@daledupreez daledupreez self-assigned this Mar 23, 2021
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 23, 2021
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~194 bytes removed 📉 [gzipped])

name   parsed_size           gzip_size
email       -533 B  (-0.1%)     -194 B  (-0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@hambai hambai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and those changes work as expected!

@daledupreez daledupreez merged commit 4af96ba into trunk Mar 24, 2021
@daledupreez daledupreez deleted the update/refactor-email-comparison-features branch March 24, 2021 11:55
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants