-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update email comparison page layout #51307
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1369 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
8eb7fd9
to
ff44e74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I tested this and there is one more error that needs fixing, but otherwise the code looks good.
I have a few minor questions/observations:
- If there is a titan mailbox in the cart already you can't add more mailboxes - you get the following error:
Only one email product per domain is supported in the cart at a time
but that is a bit confusing as technically we allow you to purchase more than one mailbox at once - but you need to remove the cart item first. Maybe we can improve the error message? Or show the cart button in the email comparison page? - I'm a bit confused by the location of the "Remove mailbox" button. Shouldn't it go next to the "Add mailbox" button? Also - nitpicking here - should we disable/hide the "Remove mailbox" button if there is only one mailbox?
- The actual Titan mailboxes are not rendered in the cart item (contrary to GSuite where users are shown) in the cart line item. I guess we'll fix that in a separate PR (just want to make sure it's on our radar)
|
||
this.setState( { addingToCart: true } ); | ||
shoppingCartManager | ||
.addProductsToCart( fillInSingleCartItemAttributes( cartItem, productsList ) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (the addProductsToCart
param) should be an array - otherwise it throws an error. I tested it like this and it works:
.addProductsToCart( fillInSingleCartItemAttributes( cartItem, productsList ) ) | |
.addProductsToCart( [ fillInSingleCartItemAttributes( cartItem, productsList ) ] ) |
Thanks for reviewing and finding that bug, @hambai! 😳 To respond to your observations:
This is a side-effect of D57740-code, which added these checks to ensure that we don't allow Titan and G Suite to be bought together, as well as preventing multiple subscriptions for the same domain. We can definitely improve the messaging!
I used this approach for consistency with the G Suite controls on both counts. I am hoping we can improve both of them once we map out a better approach.
I've added a tracking card for this. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5610536 Thank you @daledupreez for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
EmailProvidersStackedComparison
component to render the new email comparison page layout and embed the relevant creation forms for Email and Google Workspace.titan/provision-mailboxes
feature flag.Screenshots
Email expanded (the default)
Google Workspace/G Suite expanded
Email Forwarding expanded
Testing instructions
Navigate to the live branch, and then add
?flags=titan/provision-mailboxes
to the URL.Related to #51062
Related to #51298