Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update email comparison page layout #51307

Merged
merged 4 commits into from
Mar 24, 2021

Conversation

daledupreez
Copy link
Contributor

@daledupreez daledupreez commented Mar 23, 2021

Changes proposed in this Pull Request

Screenshots

Email expanded (the default)
Email expanded

Google Workspace/G Suite expanded
Google expanded

Email Forwarding expanded
Email Forwarding expanded

Testing instructions

Navigate to the live branch, and then add ?flags=titan/provision-mailboxes to the URL.

  • Try to add each of Email, Google Workspace, and Email Forwarding to your account.
  • For each provider, check that the error handling is working, and that we track clicks on the expand buttons as well as the "Add " buttons.
  • You should verify that the shopping cart entry created for Titan and Google Workspace includes the correct user/mailbox data. (We are addressing some back end bugs for Titan, so full testing here may trip over those issues.)

Related to #51062
Related to #51298

@daledupreez daledupreez added the Professional Email Issues with Professional Email powered by Titan label Mar 23, 2021
@daledupreez daledupreez requested a review from a team March 23, 2021 11:18
@daledupreez daledupreez self-assigned this Mar 23, 2021
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 23, 2021
@matticbot
Copy link
Contributor

matticbot commented Mar 23, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1369 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
email      +8668 B  (+2.0%)    +1369 B  (+1.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Base automatically changed from update/refactor-email-comparison-features to trunk March 24, 2021 11:55
@daledupreez daledupreez force-pushed the update/email-comparison-page-layout branch from 8eb7fd9 to ff44e74 Compare March 24, 2021 11:57
Copy link
Contributor

@hambai hambai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I tested this and there is one more error that needs fixing, but otherwise the code looks good.

I have a few minor questions/observations:

  1. If there is a titan mailbox in the cart already you can't add more mailboxes - you get the following error: Only one email product per domain is supported in the cart at a time but that is a bit confusing as technically we allow you to purchase more than one mailbox at once - but you need to remove the cart item first. Maybe we can improve the error message? Or show the cart button in the email comparison page?
  2. I'm a bit confused by the location of the "Remove mailbox" button. Shouldn't it go next to the "Add mailbox" button? Also - nitpicking here - should we disable/hide the "Remove mailbox" button if there is only one mailbox?
  3. The actual Titan mailboxes are not rendered in the cart item (contrary to GSuite where users are shown) in the cart line item. I guess we'll fix that in a separate PR (just want to make sure it's on our radar)


this.setState( { addingToCart: true } );
shoppingCartManager
.addProductsToCart( fillInSingleCartItemAttributes( cartItem, productsList ) )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (the addProductsToCart param) should be an array - otherwise it throws an error. I tested it like this and it works:

Suggested change
.addProductsToCart( fillInSingleCartItemAttributes( cartItem, productsList ) )
.addProductsToCart( [ fillInSingleCartItemAttributes( cartItem, productsList ) ] )

@daledupreez
Copy link
Contributor Author

Thanks for reviewing and finding that bug, @hambai! 😳

To respond to your observations:

  1. If there is a titan mailbox in the cart already you can't add more mailboxes - you get the following error: Only one email product per domain is supported in the cart at a time but that is a bit confusing as technically we allow you to purchase more than one mailbox at once - but you need to remove the cart item first. Maybe we can improve the error message? Or show the cart button in the email comparison page?

This is a side-effect of D57740-code, which added these checks to ensure that we don't allow Titan and G Suite to be bought together, as well as preventing multiple subscriptions for the same domain. We can definitely improve the messaging!

  1. I'm a bit confused by the location of the "Remove mailbox" button. Shouldn't it go next to the "Add mailbox" button? Also - nitpicking here - should we disable/hide the "Remove mailbox" button if there is only one mailbox?

I used this approach for consistency with the G Suite controls on both counts. I am hoping we can improve both of them once we map out a better approach.

  1. The actual Titan mailboxes are not rendered in the cart item (contrary to GSuite where users are shown) in the cart line item. I guess we'll fix that in a separate PR (just want to make sure it's on our radar)

I've added a tracking card for this.

@daledupreez daledupreez merged commit 5d112dc into trunk Mar 24, 2021
@daledupreez daledupreez deleted the update/email-comparison-page-layout branch March 24, 2021 19:14
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 24, 2021
@a8ci18n
Copy link

a8ci18n commented Mar 24, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5610536

Thank you @daledupreez for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Apr 8, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Professional Email Issues with Professional Email powered by Titan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants