Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Portal: Add a dummy page for the upcoming Billing Dashboard #51906

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

atanas-dev
Copy link
Member

@atanas-dev atanas-dev commented Apr 13, 2021

Context: p1HpG7-bsW-p2

This is a split from #51692 to introduce the new page and route changes.

Changes proposed in this Pull Request

  • Add a dummy page for the upcoming Billing Dashboard in the development environment only.

Testing instructions

  • If you do not have a partner key, please contact Infinity for one or you will be unable to view test this PR.
  • Check out this PR locally, then run yarn && yarn start-jetpack-cloud.
  • The license listing was moved to /partner-portal/licenses - this PR should not affect the behavior except to make sure all relevant redirects lead to /partner-portal/licenses instead of /partner-portal (e.g. issuing licenses, filtering the license list, pagination etc.).
  • A new Billing page with placeholder data should now be the default page for the Partner Portal.
  • Make sure the UI matches the designs.

Screenshot

@atanas-dev atanas-dev added [Status] In Progress Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Apr 13, 2021
@atanas-dev atanas-dev self-assigned this Apr 13, 2021
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Apr 13, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~4 bytes removed 📉 [gzipped])

name        parsed_size           gzip_size
entry-main        +36 B  (+0.0%)       -4 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~6170 bytes added 📈 [gzipped])

name                          parsed_size            gzip_size
jetpack-cloud-partner-portal     +26406 B  (+22.9%)    +6170 B  (+17.6%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@atanas-dev atanas-dev force-pushed the add/partner-portal-billing-dashboard-dummy-page branch from beceacc to 4db741a Compare April 14, 2021 18:09
@atanas-dev atanas-dev requested a review from a team April 14, 2021 18:13
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 14, 2021
@atanas-dev atanas-dev marked this pull request as ready for review April 14, 2021 18:14
@atanas-dev atanas-dev merged commit c107cf4 into trunk Apr 16, 2021
@atanas-dev atanas-dev deleted the add/partner-portal-billing-dashboard-dummy-page branch April 16, 2021 11:12
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 16, 2021
@a8ci18n
Copy link

a8ci18n commented Apr 16, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5713393

Thank you @atanas-dev for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Apr 22, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants