Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Portal: Add Billing Dashboard #51692

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

atanas-dev
Copy link
Member

@atanas-dev atanas-dev commented Apr 5, 2021

Blocked by

Changes proposed in this Pull Request

  • Add a Billing dashboard to the Partner Portal.

Testing instructions

  • If you do not have a partner key, please contact Infinity for one or you will be unable to view test this PR.
  • Check out this PR locally, then run yarn && yarn start-jetpack-cloud.
  • Make sure data matches the expected results for the selected partner key.

Screenshot 2021-04-06 at 18 46 39

@atanas-dev atanas-dev added [Status] In Progress Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Apr 5, 2021
@atanas-dev atanas-dev requested a review from a team April 5, 2021 17:43
@atanas-dev atanas-dev self-assigned this Apr 5, 2021
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 5, 2021
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Apr 5, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~68 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
jetpack-cloud-partner-portal      +1388 B  (+1.0%)      +68 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@atanas-dev atanas-dev force-pushed the add/partner-portal-billing-dashboard branch from 9dddf7f to 6881265 Compare April 13, 2021 16:34
@atanas-dev atanas-dev force-pushed the add/partner-portal-billing-dashboard branch from fb8b12c to 6510fa7 Compare April 15, 2021 14:36
@atanas-dev atanas-dev changed the base branch from trunk to add/partner-portal-billing-dashboard-dummy-page April 15, 2021 14:36
@atanas-dev atanas-dev force-pushed the add/partner-portal-billing-dashboard branch from 6510fa7 to 2133c22 Compare April 15, 2021 14:42
@atanas-dev atanas-dev marked this pull request as ready for review April 15, 2021 14:53
Base automatically changed from add/partner-portal-billing-dashboard-dummy-page to trunk April 16, 2021 11:12
@atanas-dev atanas-dev force-pushed the add/partner-portal-billing-dashboard branch from 2133c22 to 72ecda1 Compare April 16, 2021 11:13
Copy link
Contributor

@IanRamosC IanRamosC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It tests well! Feel free to merge it when the API is online.

@atanas-dev atanas-dev merged commit 9310747 into trunk Apr 19, 2021
@atanas-dev atanas-dev deleted the add/partner-portal-billing-dashboard branch April 19, 2021 16:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 19, 2021
@a8ci18n
Copy link

a8ci18n commented Apr 19, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5728730

Thank you @atanas-dev for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Apr 30, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants