Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Portal: Fix billing dashboard header flex wrap #52689

Merged
merged 1 commit into from
May 12, 2021

Conversation

IanRamosC
Copy link
Contributor

Changes proposed in this Pull Request

  • Minor adjustment to the Billing Dashboard header

Testing instructions

  • If you do not have a partner key, please contact Infinity for one or you will be unable to view the UI.

  • Checkout PR locally, run yarn && yarn start-jetpack-cloud.

  • Visit http://jetpack.cloud.localhost:3000/partner-portal, and select a partner key if you are prompted

  • Check the header across different breakpoints and make sure it looks like the screenshot below

  • Before:
    image

  • After:
    image

@IanRamosC IanRamosC added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels May 7, 2021
@IanRamosC IanRamosC requested a review from a team May 7, 2021 23:47
@IanRamosC IanRamosC self-assigned this May 7, 2021
@github-actions
Copy link

github-actions bot commented May 7, 2021

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@atanas-dev atanas-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IanRamosC IanRamosC merged commit 8a70f2c into trunk May 12, 2021
@IanRamosC IanRamosC deleted the fix/partner-portal-billing-dashboard-header branch May 12, 2021 17:15
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants