logmeinUrl package and usage

[lsl]

Changes proposed in this Pull Request

• Add logmeingUrl method to append the logmein parameter defined in D61461-code

Testing instructions

• Apply D61461-code (dependency, since deployed)
• Login to http://calypso.localhost:3000/, create a private site with a mapped domain (or log into my test user for testing23465324891.home.blog/)
• oauth flag set for testing without 3pc, and logmein flag set for testing this feature, e.g. visit http://calypso.localhost:3000/?flags=oauth,logmein
• Click here:

You should end up the site in a logged in state with cookies against the mapped domain.

• Test both while logged out of the test site directly.
• Test sub.subdomain.blog domains include the param
• Test mapped.com domains include the param
• Test wpcomstaging urls do not include the param
• Test domain redirects do not include the param
• Test Atomic sites do not include the param

For testing in calypso using chrome with third party cookies disabled you'll need to use calypso's oauth mode, e.g. http://calypso.localhost:3000/domains/manage/testing23465324891.home.blog?flags=oauth,logmein.

Unit tests:

yarn test-client client/lib/logmein

Related to #52741 / #52740 / #52763

[github-actions]

Test live: https://calypso.live/?branch=add/logmein

[aneeshd16]

Adding a link on the domain management page would also work!

wp-calypso/client/my-sites/domains/domain-management/list/index.jsx

Line 401 in e9998f7

href={ selectedSite.URL }

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~304 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains       +667 B  (+0.1%)     +304 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[niranjan-uma-shankar]

Instead of appending logmein param, would it make sense to directly take a logged in user to the the r-login.wordpress.com endpoint? If the user is in Calypso and logged in, we don't need to take them to wordpress.com/log-in - we can take them to https://r-login.wordpress.com/remote-login.php?action=link&back=https://{MAPPED_DOMAIN.tld} and save the extra log in screen step:

Appending logmein=1 is okay if we find the user is logged out for some reason. So, I'm thinking:

if ( isLoggedIn ) {
  navigate to https://r-login.wordpress.com/remote-login.php?action=link&back=https://{MAPPED_DOMAIN.tld}
} else {
  navigate to https://mapped-domain.tld/?logmein=1
}

A scenario in which this may not work is if the user has Calypso open in a tab, logs out of WPCOM in a different tab, and clicks on "Visit site" button on the open Calypso tab. Then they'll still be logged in to the mapped domain even though they're not signed in to WPCOM. Probably there are some checks we can add to handle this.

[lsl]

This should be fine, I'll see what I can do.

[lsl]

I tried this here: https://github.com/Automattic/wp-calypso/pull/52909/files#diff-d025c6a21229fe69836222916356ee8a2c395861252a82ff88e97b9facc70a4bR31

But it didn't seem to work for some reason (didn't dig too deep) end up getting js output as plaintext directly from `remote-login.php

[niranjan-uma-shankar]

Should we also add these logmein links to the editor?

A couple of other places:

In themes page after activating a theme:

In the Reader where the title links to the mapped domain site:

[lsl]

Reworked this as a client lib for simplicity and updated code to match up with what @JoshuaGoode is dropping in the demo. Depends on the latest update in D61461-code.

Edit: Just noticed I nuked the tests in the process, will add them back tomorrow and amend to include the new selector. (Maybe, if we're still going this way)

[niranjan-uma-shankar]

This should work, since I have a similar implementation in #53125 and it works well. One thing to note is that the back URL should be https instead of http. When I tested this PR by clicking on the mapped domain link on the domain management page, I was taken to the following URL which outputted JS on the screen:

https://r-login.wordpress.com/remote-login.php?action=link&back=http%3A%2F%2Fniranjan792177516.blog

Note the http in the back URL. When I changed that https, then the r-login redirect worked well.

Anyhow, with the change in D61461-code to skip the Continue step, is this change still needed?

[niranjan-uma-shankar]

Would you like to include in this PR the logmeinUrl()'ification of other instances in Calypso that link to the mapped domain URL? We might have to do this in the editor, reader and so on. Or do you think we should take that as a separate PR?

[lsl]

I'm not sure if this is the correct list of restrictions.. do we have an "is simple site" method by chance?

[niranjan-uma-shankar]

I don't know the right answer to this, but here's what I found.
We have this selector that returns true if a site is a WPCOM site(atomic or simple) as described the JS Doc:

Whether the site is a WPCOM site ( Atomic or Simple )

Using the logic in that selector, the following should return simple sites:

! isJetpackSite( state, siteId ) || ! isAtomicSite( state, siteId )

Would this be the right check for WPCOM simple sites?

[lsl]

Moving focus to replacement: #53443