Jetpack site-less Checkout: hide references to siteless.jetpack.com domain from Purchases section

[rcanepa]

Changes proposed in this Pull Request

• Remove references to siteless.jetpack.com from the Purchases section that don't add useful information and might be confusing to some users.

Testing instructions

• Run this PR locally with yarn start.
• Sandbox public-api.wordpress.com.
• Enable USE_STORE_SANDBOX so you can use a fake credit card (using credits makes appear many other warnings in the Purchase section and we won't be dealing with them on this PR).
• Purchase a product and a plan.
• Visit the /me/purchases section.
• Make sure the purchases look like in the PR (you should not see any reference to siteless.jetpack.com).
• Visit the purchase records of both the product and the plan.
• Make sure the purchase records look like in the PR (you should not see any reference to siteless.jetpack.com).
• Go through the cancellation flow and make sure the last step looks like the capture below (no references to siteless.jetpack.com).

Related to 1200479326344990-as-1200641987599725

Demo

The images on the left correspond to how things look now in production, on the right how they look after these changes.

/me/purchases

/me/purchases/siteless.jetpack.com/:purchaseId – Product view

/me/purchases/siteless.jetpack.com/:purchaseId – Plan view

/me/purchases/siteless.jetpack.com/:purchaseId – Cancel product modal

/me/purchases/siteless.jetpack.com/:purchaseId – Cancel plan modal

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~293 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
site-purchases       +796 B  (+0.1%)     +247 B  (+0.1%)
purchases            +796 B  (+0.1%)     +247 B  (+0.1%)
email                +142 B  (+0.0%)      +46 B  (+0.0%)
domains              +142 B  (+0.0%)      +47 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[atanas-dev]

https://github.com/Automattic/wp-calypso/blob/update/me-purchases-references-to-siteless-jetpack/client/me/purchases/remove-purchase/index.jsx#L256 also has a reference to the domain when trying to remove a plan.
Since I see that modal in your screenshots maybe you've missed to commit that change?

Other than the above - LGTM 👍

[rcanepa]

https://github.com/Automattic/wp-calypso/blob/update/me-purchases-references-to-siteless-jetpack/client/me/purchases/remove-purchase/index.jsx#L256 also has a reference to the domain when trying to remove a plan.
Since I see that modal in your screenshots maybe you've missed to commit that change?

Other than the above - LGTM 👍

Instead of patching that line, I decided to hide the button that allows users to remove or cancel a subscription. This is because I think users would rather ask for a refund than remove/cancel their subscription.

[matticbot]

This PR modifies the release build for notifications

To test your changes on WordPress.com, run install-plugin.sh notifications update/me-purchases-references-to-siteless-jetpack on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-elI-p2

[matticbot]

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-11243
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:build-11243&env=jetpack

[matticbot]

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit update/me-purchases-references-to-siteless-jetpack on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

[cbauerman]

Looks good!

I decided to hide the button that allows users to remove or cancel a subscription. This is because I think users would rather ask for a refund than remove/cancel their subscription.

I also think this knocks out 1200479326344990-as-1200631299519252

LGTM!

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6287644

Thank you @rcanepa for including a screenshot in the description! This is really helpful for our translators.

[a8ci18n]

Translation for this Pull Request has now been finished.