allows siteless purchases to be removed

[jboland88]

Proposed Changes

This PR allows Jetpack license purchases that are not assigned to a site to be removed. At the moment, license based purchases can only be removed from a user account after they are attached to a real Jetpack site.

This restriction was first introduced here: #54853

See references for more context:

• 1200479326344990-as-1200631299519252
• D63228#1321598-code
• pNPgK-5gx-p2#comment-21275

This restriction is not particularly necessary, removing it makes subscription management for licenses less cumbersome.

Testing Instructions

• Obtain a siteless (license) Jetpack purchase
• With this patch applied, confirm that you can remove the purchase yourself from the purchase management in Calypso

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-6934f57f8cf06a134be53434802a8514188731d7

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-6934f57f8cf06a134be53434802a8514188731d7&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~16 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
domains               +60 B  (+0.0%)      +17 B  (+0.0%)
site-purchases        +45 B  (+0.0%)      +16 B  (+0.0%)
purchases             +45 B  (+0.0%)      +16 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[robertsreberski]

Code looks good, I confirm I can cancel Jetpack siteless subscriptions!