Purchases: Adjust modal message when deleting a Domain Mapping subscription.

[chrisfromthelc]

Changes proposed in this Pull Request

• As suggested in Mappings: Confusing Message When Removing It #49043, this PR will adjust the messaging when deleting a Domain Mapping subscription in order to better communicate the ramifications of removing it.

Testing instructions

1. Add a domain mapping to any plan.
2. Navigate through Upgrades > Domains > click on the domain mapping.
3. Click Delete Domain Mapping at the bottom.

You should be presented with a modal showing an updated message:

Are you sure you want to remove DOMAIN from SITEADDRESS? You will not be able to reuse DOMAIN again without starting a new Domain Mapping subscription.

Related to #49043

[github-actions]

Link to live branch is being generated...
Please wait a few minutes and refresh this page.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~104 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
site-purchases       +879 B  (+0.1%)     +104 B  (+0.0%)
purchases            +879 B  (+0.1%)     +104 B  (+0.0%)
domains              +879 B  (+0.1%)     +104 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[DavidRothstein]

Thanks for working on this!

[chrisfromthelc]

@DavidRothstein After thinking on this further and digging around a bit more this evening, I'm wondering if it might be advantageous to treat removing a mapping like we would a registered domain. The registered domain code handling the deletion messaging has a series of checks to see if the user's account email is based on the deleting domain, if there is Titan email for the domain, etc.

https://github.com/Automattic/wp-calypso/blob/trunk/client/me/purchases/remove-purchase/remove-domain-dialog/index.jsx

I have encountered a number of users who have deleted/let expire a domain mapping where there were secondary effects like these, so it seems prudent to take similar steps like we would with a registered domain. We can have a customized modal/flow for mapping and rework the other text (what was originally to be changed with this PR) to something that works better for the other products.

[DavidRothstein]

@chrisfromthelc - hm, interesting idea! I guess it's true that removing a domain mapping is similarly destructive to a site as removing a domain registration. (Although the main difference is that removing a domain mapping is easier to recover from if you do it by mistake.)

In principal I do think something like this could work and would make sense, but I wonder how much effort is involved. It seems to me like it would probably be a lot harder than just changing the text of the existing dialog... So overall, I don't know 🤷

[chrisfromthelc]

In principal I do think something like this could work and would make sense, but I wonder how much effort is involved.

Since this isn't a very urgent issue, I'm looking into this to see what I can figure out, and it'll be a good learning experience on building out this kind of functionality.

[chrisfromthelc]

I reworked this, adding a new render for Domain Mapping specifically:

The plans modal will have the original version of the message:

We can tweak the messaging further if needed, but now that they're completely separated, we don't need to genericize the text as much as originally planned.

[jjchrisdiehl]

Tested - looks good to me:

Domain mapping

Plans

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6546680

Thank you @chrisfromthelc for including a screenshot in the description! This is really helpful for our translators.

[a8ci18n]

Translation for this Pull Request has now been finished.