Fix/domain search box writing direction #5649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreh
added
[Status] Needs Review
|
cc @rachelmcr |
|
👍 LGTM - I would have probably just set the text field and leave the icons as is, but this is a much more complete solution. Thanks! :) |
yoavf
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5520, by introducing an option to force the direction of the search field.
I believe this is the expected interaction for this type of field, but I need someone from I18n more used to the RTL interaction to confirm this is correct. (Especially the placeholder.)
I used a
dirfield to be consistent with the HTML conventions, and some CSS trickery with classes and:not()rules. This was needed because:dir()is not yet widely implemented) and[dir="ltr"]would require me to add support for that attribute on all involved components, includingGridicon, and I didn't want to mess with that.In the long term once browsers support
:dir()that should make the code way cleaner and more correct.