Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transferred domain item statuses #56517

Merged
merged 6 commits into from
Sep 24, 2021

Conversation

leonardost
Copy link
Contributor

@leonardost leonardost commented Sep 23, 2021

Changes proposed in this Pull Request

This PR updates the transferred domain item statuses in the site domains management page. This is part of the domain transfer flow redesign detailed in pcYYhz-hK-p2.

Screenshots

These are the new transferred domain statuses:

  • Transfer pending - the limit date to begin the transfer is 25 days after the transfer subscription is bought

Screen Shot 2021-09-23 at 17 58 57

  • Transfer in progress

Screen Shot 2021-09-23 at 18 01 38

  • Transfer in progress with estimated finish time

Screen Shot 2021-09-23 at 18 02 50

  • Transfer failed

Screen Shot 2021-09-23 at 18 00 39

  • Transfer completed successfully but domain does not resolve to WPCOM yet

Screen Shot 2021-09-23 at 18 05 09

Testing instructions

  • This should be tested with D67325-code applied to your sandbox.
  • Open the live Calypso link, check the site domains management page (Upgrades > Domains) and try to find transferred domains in the following states:
    • Transfer not started (when a user chooses to use a transferred domain during onboarding)
    • Transfer in progress
    • Transfer failed
    • Transfer completed successfully and the domain does not point to WPCOM's name servers yet
  • Alternatively, run this branch locally and hack resolve-domain-status.js to force the desired domain statuses on your domains.
  • Ensure all these situations have the correct status messages and layout as described in the screenshots and pcYYhz-hK-p2.

@leonardost leonardost requested a review from a team as a code owner September 23, 2021 18:41
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 23, 2021
@matticbot
Copy link
Contributor

matticbot commented Sep 23, 2021

@github-actions
Copy link

@matticbot
Copy link
Contributor

matticbot commented Sep 23, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~411 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
domains                       +2028 B  (+0.1%)     +376 B  (+0.1%)
woocommerce-installation        +59 B  (+0.0%)      +20 B  (+0.0%)
woocommerce                     +59 B  (+0.0%)      +20 B  (+0.0%)
themes                          +59 B  (+0.0%)      +20 B  (+0.0%)
theme                           +59 B  (+0.0%)      +20 B  (+0.0%)
stats                           +59 B  (+0.0%)      +20 B  (+0.0%)
sites                           +59 B  (+0.1%)      +20 B  (+0.1%)
site-purchases                  +59 B  (+0.0%)      +20 B  (+0.0%)
signup                          +59 B  (+0.0%)      +20 B  (+0.0%)
settings-writing                +59 B  (+0.0%)      +20 B  (+0.0%)
settings-security               +59 B  (+0.0%)      +20 B  (+0.0%)
settings-performance            +59 B  (+0.0%)      +20 B  (+0.0%)
settings-jetpack                +59 B  (+0.0%)      +20 B  (+0.0%)
settings-discussion             +59 B  (+0.0%)      +20 B  (+0.0%)
settings                        +59 B  (+0.0%)      +20 B  (+0.0%)
scan                            +59 B  (+0.0%)      +20 B  (+0.0%)
purchases                       +59 B  (+0.0%)      +15 B  (+0.0%)
preview                         +59 B  (+0.0%)      +20 B  (+0.0%)
posts-custom                    +59 B  (+0.0%)      +20 B  (+0.0%)
posts                           +59 B  (+0.0%)      +20 B  (+0.0%)
plugins                         +59 B  (+0.0%)      +20 B  (+0.0%)
plans                           +59 B  (+0.0%)      +20 B  (+0.0%)
people                          +59 B  (+0.0%)      +20 B  (+0.0%)
pages                           +59 B  (+0.0%)      +20 B  (+0.0%)
migrate                         +59 B  (+0.0%)      +20 B  (+0.0%)
media                           +59 B  (+0.0%)      +20 B  (+0.0%)
marketplace                     +59 B  (+0.0%)      +20 B  (+0.0%)
marketing                       +59 B  (+0.0%)      +20 B  (+0.0%)
jetpack-search                  +59 B  (+0.0%)      +20 B  (+0.0%)
jetpack-connect                 +59 B  (+0.0%)      +20 B  (+0.0%)
jetpack-cloud-settings          +59 B  (+0.0%)      +20 B  (+0.0%)
jetpack-cloud-pricing           +59 B  (+0.0%)      +20 B  (+0.0%)
jetpack-cloud                   +59 B  (+0.1%)      +20 B  (+0.1%)
import                          +59 B  (+0.0%)      +20 B  (+0.0%)
hosting                         +59 B  (+0.0%)      +20 B  (+0.0%)
home                            +59 B  (+0.0%)      +20 B  (+0.0%)
gutenberg-editor                +59 B  (+0.0%)      +20 B  (+0.0%)
google-my-business              +59 B  (+0.0%)      +20 B  (+0.0%)
export                          +59 B  (+0.0%)      +20 B  (+0.0%)
email                           +59 B  (+0.0%)      +20 B  (+0.0%)
earn                            +59 B  (+0.0%)      +20 B  (+0.0%)
customize                       +59 B  (+0.0%)      +20 B  (+0.0%)
concierge                       +59 B  (+0.0%)      +20 B  (+0.0%)
comments                        +59 B  (+0.0%)      +20 B  (+0.0%)
checkout                        +59 B  (+0.0%)      +20 B  (+0.0%)
beta-testing                    +59 B  (+0.0%)      +20 B  (+0.0%)
backup                          +59 B  (+0.0%)      +20 B  (+0.0%)
activity                        +59 B  (+0.0%)      +20 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@leonardost leonardost added the [Feature Group] Emails & Domains Features related to email integrations and domain management. label Sep 23, 2021
Copy link
Contributor

@delputnam delputnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulated all the different states and made sure the messages looked correct.

All LGTM. Thank you.

@leonardost leonardost merged commit 67fe361 into trunk Sep 24, 2021
@leonardost leonardost deleted the update/transferred-domain-item-statuses branch September 24, 2021 20:42
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 24, 2021
@a8ci18n
Copy link

a8ci18n commented Sep 24, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6653154

Thank you @leonardost for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 1, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants