Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning message to export library card #58238

Merged
merged 4 commits into from
Nov 19, 2021

Conversation

nelsonec87
Copy link
Contributor

Changes proposed in this Pull Request

Testing instructions

  • Open any blog on Calypso
  • Go to Tools => Export

image

Related to #28033

@nelsonec87 nelsonec87 requested a review from a team November 18, 2021 14:16
@nelsonec87 nelsonec87 self-assigned this Nov 18, 2021
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 18, 2021
@github-actions
Copy link

github-actions bot commented Nov 18, 2021

@matticbot
Copy link
Contributor

matticbot commented Nov 18, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~62 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
export       +318 B  (+0.2%)      +62 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add an Inline Support Link saying "Learn more." to the end of this notice for clarity/so the user has a next step they can take: https://wordpress.com/support/export/#exporting-the-media-library

{ translate(
'Depending on your media library size and/or connection speed you might need to use a download manager.'
) }
<InlineSupportLink supportContext="export-media-library" showIcon={ false } />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include a full stop (period) after "Learn more" like we do in the subheading:

Screen Shot 2021-11-18 at 1 23 55 PM

A good code example of this in action is here:

subHeaderText = translate(
'Create and manage all the testimonials on your site. {{learnMoreLink}}Learn more{{/learnMoreLink}}.',
{
components: {
learnMoreLink: <InlineSupportLink supportContext="testimonials" showIcon={ false } />,
},
}
);

This will also fix the missing space problem I noticed:
Screen Shot 2021-11-18 at 1 22 24 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the interpolation example!

@mreishus
Copy link
Contributor

I believe a dependent clause preceding an independent clause needs a comma to join them -> Depending on your media library size and/or connection speed, you might need to use a download manager.

Copy link
Contributor

@mreishus mreishus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mreishus
Copy link
Contributor

Noting that https://wordpress.com/support/export/#exporting-the-media-library does not say anything specifically about download managers, so we could add some text there as a follow-up

Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-11-18 at 6 33 46 PM

LGTM! 👍

@nelsonec87 nelsonec87 merged commit ce378c3 into trunk Nov 19, 2021
@nelsonec87 nelsonec87 deleted the fix/add-warning-message-to-export-library-card branch November 19, 2021 11:56
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 19, 2021
@a8ci18n
Copy link

a8ci18n commented Nov 19, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6984253

Thank you @nelsonec87 for including a screenshot in the description! This is really helpful for our translators.

@pablinos
Copy link
Contributor

I know it's not part of this PR, but should we promote the guided transfer first, or at least not last?

@a8ci18n
Copy link

a8ci18n commented Nov 29, 2021

Translation for this Pull Request has now been finished.

nelsonec87 added a commit that referenced this pull request Dec 9, 2021
* Added warning message to export library card

* Added 'Learn more' link to warning msg when exporting media library

* Media export button: Added period after "Learn more" link

* Export media button: fix grammar error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants