-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added warning message to export library card #58238
Added warning message to export library card #58238
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-19883 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~62 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add an Inline Support Link saying "Learn more." to the end of this notice for clarity/so the user has a next step they can take: https://wordpress.com/support/export/#exporting-the-media-library
{ translate( | ||
'Depending on your media library size and/or connection speed you might need to use a download manager.' | ||
) } | ||
<InlineSupportLink supportContext="export-media-library" showIcon={ false } /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include a full stop (period) after "Learn more" like we do in the subheading:
A good code example of this in action is here:
wp-calypso/client/my-sites/types/main.jsx
Lines 33 to 40 in f2e6f88
subHeaderText = translate( | |
'Create and manage all the testimonials on your site. {{learnMoreLink}}Learn more{{/learnMoreLink}}.', | |
{ | |
components: { | |
learnMoreLink: <InlineSupportLink supportContext="testimonials" showIcon={ false } />, | |
}, | |
} | |
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the interpolation example!
I believe a dependent clause preceding an independent clause needs a comma to join them -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Noting that https://wordpress.com/support/export/#exporting-the-media-library does not say anything specifically about download managers, so we could add some text there as a follow-up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6984253 Thank you @nelsonec87 for including a screenshot in the description! This is really helpful for our translators. |
I know it's not part of this PR, but should we promote the guided transfer first, or at least not last? |
Translation for this Pull Request has now been finished. |
* Added warning message to export library card * Added 'Learn more' link to warning msg when exporting media library * Media export button: Added period after "Learn more" link * Export media button: fix grammar error
Changes proposed in this Pull Request
Depending on your media library size and/or connection speed you might need to use a download manager.
, as a workaround for Media Library: Large export files are difficult to download. #28033.Testing instructions
Related to #28033