-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2 signup: add 'post-email confirmation' screen #59573
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-23577 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~42 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~21323 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1207 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
f2ac2e9
to
aa31b94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I'm missing something, since I've tried it twice, but I can only verify the account if I login first in the new tab and only afterwards paste the activation link.
Hmm, that's weird. Sounds like the second tab doesn't share your logged in session with the signup flow tab? After creating an acccount, you should be automatically logged in as that account, so it's surprising that it prompts you to log in.
When you go to wordpress.com in the second tab, does it show you are logged out?
However the issue is that reloading the "Check your email" page after I activate the account remains the same. If in the other tab I logout or I don't login in the first place reloading "Check your email" redirects me to http://calypso.localhost:3000/start/p2-new/user
http://calypso.localhost:3000/start/p2-new/user
is what a logged out user would get. If you had manually logged out via the second tab, this makes sense.
When you activated your account, did it redirect you to wordpress.com/read?verified=1
and showed a notice like this?
Also, sorry I forgot to put that you will need to build with ENABLE_FEATURES=no-force-sympathy yarn start
. Not doing this shouldn't have caused being stuck on the "Check your email" page, but it may cause skipping the "Email confirmed" page when you reload post-activation, since state rehydration might be skipped.
Here's a recording of what I'm seeing, if it helps: https://d.pr/v/sqIQQG |
Not sure what is happening, https://d.pr/v/yFH1oo but I still cannot reproduce it 🙁 |
Ahh I see now. Please turn off the Chrome incognito's third-party cookies blocking, as there'd be trouble due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Ahh I see now. Please turn off the Chrome incognito's third-party cookies blocking, as there'd be trouble due to calypso.localhost:3000 vs wordpress.com cookies.
Great catch.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7066240 Thank you @annemirasol for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
Testing instructions
ENABLE_FEATURES=no-force-sympathy yarn start
a. While logged in as a verified user, visit
calypso.localhost:3000/start/p2-new
. Since your user account is already verified, you should go straight to thep2-site
step, skipping thep2-confirm-email
step.a. In incognito mode, visit
calypso.localhost:3000/start/p2-new
and sign up for a new acccount, using an email address that you have access to.b. After signing up, you should get the "Check your email" step. Do not close this window.
c. Copy the verification link and paste it in a browser tab, within the same incognito session. This should mark your test user account as verified, but will redirect to Calypso home. The redirect will be fixed in a separate PR.
d. Return to the window in 2b and reload the page. You should get the "Email confirmed" notice. Click the "Continue" button and you should get the next step.
Screens