Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address step validation follow up #60018

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Address step validation follow up #60018

merged 2 commits into from
Jan 13, 2022

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Jan 13, 2022 •
edited
Loading

Changes proposed in this Pull Request

Testing instructions

  • Go to http://calypso.localhost:3000/woocommerce-installation/?flags=woop
  • Choose a non atomic site (atomic won't work until JP updates with new country endpoint data)
  • Click set up my store
  • You should be taken to the address step (when the woop flag is active)
  • Clicking the continue button should fail with validation errors until the form is completed correctly.

Before
Screenshot 2022-01-13 at 13-58-06 Add WooCommerce to your site — WordPress com

After
Screenshot 2022-01-13 at 16-54-22 Add WooCommerce to your site — WordPress com

Related to #

@github-actions
Copy link

github-actions bot commented Jan 13, 2022 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-24595
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-24595&env=jetpack

@lsl lsl marked this pull request as ready for review January 13, 2022 05:57
@lsl lsl self-assigned this Jan 13, 2022
@lsl lsl changed the title Fix error message for email address Address step validation follow up Jan 13, 2022
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@lsl lsl mentioned this pull request Jan 13, 2022
Merged
allilevine
allilevine approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the fixes and the errors are showing up correctly. When I fix the errors the form submits.

@DustyReagan DustyReagan self-requested a review January 13, 2022 15:31
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2022
DustyReagan
DustyReagan approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obenland obenland added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 13, 2022
@DustyReagan DustyReagan merged commit a32c153 into trunk Jan 13, 2022
@DustyReagan DustyReagan deleted the update/woop-validation branch January 13, 2022 16:19
@a8ci18n
Copy link

a8ci18n commented Jan 13, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7083170

Thank you @lsl for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jan 21, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustyReagan DustyReagan DustyReagan approved these changes

@allilevine allilevine allilevine approved these changes

Assignees

@lsl lsl

Labels
None yet
Projects
Woo on Plans
Status: 🎉 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lsl @matticbot @a8ci18n @DustyReagan @allilevine @obenland