Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change wordings and a bit of style for p2 creation #60640

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Change wordings and a bit of style for p2 creation #60640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc0874d
Change wordings and a bit of style for signup
naxoc Jan 28, 2022
6fb203c
Merge branch 'trunk' into fix/p2-processing-screen-wording
naxoc Feb 1, 2022
94e1aff
Feedback from review
naxoc Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/signup/p2-processing-screen/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function P2SignupProcessingScreen() {
</div>

<div className="p2-processing-screen__text">
{ translate( '{{h2}}Hooray!{{/h2}} {{p}}Your new P2 is almost ready.{{/p}}', {
{ translate( '{{h2}}Hooray!{{/h2}} {{p}}Your new P2 workspace is almost ready.{{/p}}', {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 This change will be queued for retranslation. We'll use the existing translations in the meantime.

components: {
// eslint-disable-next-line jsx-a11y/heading-has-content
h2: <h2 />,
Expand Down
4 changes: 3 additions & 1 deletion client/signup/p2-step-wrapper/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Path, SVG } from '@wordpress/components';
import { Icon } from '@wordpress/icons';
import classnames from 'classnames';
import { useTranslate } from 'i18n-calypso';
import PropTypes from 'prop-types';
import StepWrapper from 'calypso/signup/step-wrapper';
Expand All @@ -14,11 +15,12 @@ function P2StepWrapper( {
subHeaderText,
positionInFlow,
children,
className,
} ) {
const translate = useTranslate();

return (
<div className="p2-step-wrapper">
<div className={ classnames( 'p2-step-wrapper', className ) }>
<div className="p2-step-wrapper__header">
<div className="p2-step-wrapper__header-logo">
<SVG xmlns="http://www.w3.org/2000/svg" width="67" height="32" viewBox="0 0 67 32">
Expand Down
10 changes: 6 additions & 4 deletions client/signup/steps/p2-site/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ class P2Site extends Component {
className="p2-site__validation-site-title"
>
<FormLabel htmlFor="site-title-input">
{ this.props.translate( 'Name your team' ) }
{ this.props.translate( 'Name your workspace' ) }
</FormLabel>
<FormTextInput
id="site-title-input"
Expand All @@ -404,7 +404,7 @@ class P2Site extends Component {
className="p2-site__validation-site"
>
<FormLabel htmlFor="site-address-input">
{ this.props.translate( 'Choose an address for your P2 workspace' ) }
{ this.props.translate( 'Choose an address for your workspace' ) }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 This change will be queued for retranslation. We'll use the existing translations in the meantime.

</FormLabel>
<div className="p2-site__site-url-container">
<FormTextInput
Expand Down Expand Up @@ -461,11 +461,13 @@ class P2Site extends Component {
render() {
return (
<P2StepWrapper
className="p2-site__create"
flowName={ this.props.flowName }
stepName={ this.props.stepName }
positionInFlow={ this.props.positionInFlow }
headerText={ this.props.translate(
'Share, discuss, review, and collaborate across time zones, without interruptions.'
headerText={ this.props.translate( 'Create a workspace' ) }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 19 times:
translate( 'Create a new workspace' ) ES Score: 6

subHeaderText={ this.props.translate(
'Your workspace is where you will create all the different P2s for teams, projects, topics, etc.'
) }
>
<form className="p2-site__form" onSubmit={ this.handleSubmit } noValidate>
Expand Down
7 changes: 7 additions & 0 deletions client/signup/steps/p2-site/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
.p2-site__create {
.p2-step-wrapper__header-text {
font-size: var( --p2-font-size-form-xl );
font-weight: 700;
}
}

.p2-site__site-url-container {
position: relative;
}
Expand Down