Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans comparison: make "not" in features' list bold on mobile #62557

Merged
merged 1 commit into from
May 6, 2022

Conversation

chriskmnds
Copy link
Contributor

@chriskmnds chriskmnds commented Apr 6, 2022

Changes proposed in this Pull Request

Partially addresses c/4PHxCS4J-tr

Makes "not" in the features list bold on mobile.

Media

Screenshot 2022-04-06 at 3 43 18 PM

Testing instructions

  1. Go to /start/plans
  2. Switch to mobile viewport and ensure "not" appears bold in the plan features comparison list.
  3. Go to /plans/[SITE_URL] with a personal site and ensure the same for 2 above.

TODO

  • Create respective Landpack PR. 1013-gh-Automattic/landpack
  • Create respective WPCOM diff for Landpack changes. D78915-code (generated via yarn deploy)
  • Create respective WPCOM diff for landing pages. (TBD D78440-code)
  • Create respective LOHP diff (regeneration). D78443-code

Related to #

@chriskmnds chriskmnds added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 6, 2022
@chriskmnds chriskmnds self-assigned this Apr 6, 2022
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~20 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
themes                     +975 B  (+0.2%)      +20 B  (+0.0%)
settings-performance       +975 B  (+0.2%)      +20 B  (+0.0%)
scan                       +975 B  (+0.1%)      +20 B  (+0.0%)
plugins                    +975 B  (+0.1%)      +20 B  (+0.0%)
plans                      +975 B  (+0.1%)      +20 B  (+0.0%)
migrate                    +975 B  (+0.3%)      +20 B  (+0.0%)
media                      +975 B  (+0.0%)      +20 B  (+0.0%)
marketplace                +975 B  (+0.1%)      +20 B  (+0.0%)
hosting                    +975 B  (+0.2%)      +20 B  (+0.0%)
home                       +975 B  (+0.1%)      +20 B  (+0.0%)
earn                       +975 B  (+0.2%)      +20 B  (+0.0%)
domains                    +975 B  (+0.1%)      +20 B  (+0.0%)
checkout                   +975 B  (+0.1%)      +20 B  (+0.0%)
backup                     +975 B  (+0.1%)      +20 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~20 bytes added 📈 [gzipped])

name                                                             parsed_size           gzip_size
async-load-signup-steps-plans                                         +975 B  (+0.3%)      +20 B  (+0.0%)
async-load-signup-steps-import-from-wordpress-import-everything       +975 B  (+0.3%)      +20 B  (+0.0%)
async-load-signup-steps-import-from-wordpress                         +975 B  (+0.1%)      +20 B  (+0.0%)
async-load-signup-steps-import-from                                   +975 B  (+0.1%)      +20 B  (+0.0%)
async-load-signup-steps-domains                                       +975 B  (+0.2%)      +20 B  (+0.0%)
async-load-design-blocks                                              +975 B  (+0.0%)      +20 B  (+0.0%)
async-load-calypso-post-editor-media-modal                            +975 B  (+0.1%)      +20 B  (+0.0%)
async-load-calypso-post-editor-editor-media-modal                     +975 B  (+0.1%)      +20 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                            +975 B  (+0.1%)      +20 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                       +975 B  (+0.1%)      +20 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -120,7 +120,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [

return feature
? translate( 'Custom domain name is free for one year!' )
: translate( 'Custom domain name is not included' );
: translate( 'Custom domain name is {{strong}}not{{/strong}} included', {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niranjan-uma-shankar will this create a new call for translations? Any thoughts to get around if so, as it's only stylistic changes? :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylistic changes

in en at least 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will only result in some fuzzy strings which can be resolved relatively easy. We can also add "String Freeze" label to see what will happen :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about String Freeze. I may not recall correctly, but I think we merged stuff early behind features flags in the past to get translations before rollout, but this is obviously a solver (if I understand).

cc @razvanpapadopol 😎

Copy link

@razvanpapadopol razvanpapadopol Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Status] String Freeze label is used for Calypso changes where you want to have the strings translated before you merge the PR. Otherwise, even without using the GH label, they will be sent for translation when the PR is merged but you should make sure there is a mechanism in place to prevent showing the untranslated strings to real users. Read more in FG: PCYsg-3hI-p2#calypso

we merged stuff early behind features flags in the past to get translations before rollout

This is the only way for ETK, where the process starts only after a version of the plugin containing those strings is released. Read more about ETK processs: PCYsg-ly5-p2#i18n

Copy link
Contributor Author

@chriskmnds chriskmnds Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. Indeed recall the ETK scenario now. So yeah, different process. Thanks for the insight/summary! 😎

@southp southp added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Apr 18, 2022
@a8ci18n
Copy link

a8ci18n commented Apr 18, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7227965

Thank you @chriskmnds for including a screenshot in the description! This is really helpful for our translators.

Copy link
Contributor

@southp southp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that it works as expected. LGTM 🚢

@a8ci18n
Copy link

a8ci18n commented Apr 23, 2022

Translation for this Pull Request has now been finished.

@chriskmnds chriskmnds removed the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label May 6, 2022
@chriskmnds chriskmnds merged commit e14cccb into trunk May 6, 2022
@chriskmnds chriskmnds deleted the update/plans-comparison-bold-not branch May 6, 2022 10:14
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants