-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans comparison: make "not" in features' list bold on mobile #62557
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~20 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~20 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -120,7 +120,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [ | |||
|
|||
return feature | |||
? translate( 'Custom domain name is free for one year!' ) | |||
: translate( 'Custom domain name is not included' ); | |||
: translate( 'Custom domain name is {{strong}}not{{/strong}} included', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niranjan-uma-shankar will this create a new call for translations? Any thoughts to get around if so, as it's only stylistic changes? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stylistic changes
in en
at least 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this will only result in some fuzzy strings which can be resolved relatively easy. We can also add "String Freeze" label to see what will happen :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about String Freeze
. I may not recall correctly, but I think we merged stuff early behind features flags in the past to get translations before rollout, but this is obviously a solver (if I understand).
cc @razvanpapadopol 😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Status] String Freeze
label is used for Calypso changes where you want to have the strings translated before you merge the PR. Otherwise, even without using the GH label, they will be sent for translation when the PR is merged but you should make sure there is a mechanism in place to prevent showing the untranslated strings to real users. Read more in FG: PCYsg-3hI-p2#calypso
we merged stuff early behind features flags in the past to get translations before rollout
This is the only way for ETK, where the process starts only after a version of the plugin containing those strings is released. Read more about ETK processs: PCYsg-ly5-p2#i18n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. Indeed recall the ETK scenario now. So yeah, different process. Thanks for the insight/summary! 😎
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7227965 Thank you @chriskmnds for including a screenshot in the description! This is really helpful for our translators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that it works as expected. LGTM 🚢
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
Partially addresses c/4PHxCS4J-tr
Makes "not" in the features list bold on mobile.
Media
Testing instructions
/start/plans
bold
in the plan features comparison list./plans/[SITE_URL]
with a personal site and ensure the same for 2 above.TODO
yarn deploy
)Related to #