Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plans comparison: make "not" in features' list bold on mobile #62557

Merged
merged 1 commit into from
May 6, 2022
Merged

Plans comparison: make "not" in features' list bold on mobile #62557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 45 additions & 15 deletions client/my-sites/plans-comparison/plans-comparison-features.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [

return feature
? translate( 'Custom domain name is free for one year!' )
: translate( 'Custom domain name is not included' );
: translate( 'Custom domain name is {{strong}}not{{/strong}} included', {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niranjan-uma-shankar will this create a new call for translations? Any thoughts to get around if so, as it's only stylistic changes? :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylistic changes

in en at least 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will only result in some fuzzy strings which can be resolved relatively easy. We can also add "String Freeze" label to see what will happen :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about String Freeze. I may not recall correctly, but I think we merged stuff early behind features flags in the past to get translations before rollout, but this is obviously a solver (if I understand).

cc @razvanpapadopol 😎

Copy link

@razvanpapadopol razvanpapadopol Apr 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Status] String Freeze label is used for Calypso changes where you want to have the strings translated before you merge the PR. Otherwise, even without using the GH label, they will be sent for translation when the PR is merged but you should make sure there is a mechanism in place to prevent showing the untranslated strings to real users. Read more in FG: PCYsg-3hI-p2#calypso

we merged stuff early behind features flags in the past to get translations before rollout

This is the only way for ETK, where the process starts only after a version of the plugin containing those strings is released. Read more about ETK processs: PCYsg-ly5-p2#i18n

Copy link
Contributor Author

@chriskmnds chriskmnds Apr 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. Indeed recall the ETK scenario now. So yeah, different process. Thanks for the insight/summary! 😎

components: { strong: <strong /> },
} );
},
},
{
Expand All @@ -138,7 +140,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [
if ( isMobile ) {
cellText = feature
? translate( 'Premium themes are included' )
: translate( 'Premium themes are not included' );
: translate( 'Premium themes are {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
}
return cellText;
},
Expand Down Expand Up @@ -177,7 +181,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [

return feature
? translate( 'Unlimited WordPress plugins' )
: translate( 'WordPress plugins are not included' );
: translate( 'WordPress plugins are {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
},
},
{
Expand All @@ -198,7 +204,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [
if ( isMobile ) {
cellText = feature
? translate( 'Premium support is included' )
: translate( 'Premium support is not included' );
: translate( 'Premium support is {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
}
return cellText;
},
Expand All @@ -218,7 +226,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [
if ( isMobile ) {
cellText = feature
? translate( 'WooCommerce is included' )
: translate( 'WooCommerce is not included' );
: translate( 'WooCommerce is {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
}
return cellText;
},
Expand Down Expand Up @@ -267,7 +277,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [
if ( isMobile ) {
cellText = feature
? translate( 'Remove ads is included' )
: translate( 'Remove ads is not included' );
: translate( 'Remove ads is {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
}
return cellText;
},
Expand All @@ -288,7 +300,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [
if ( isMobile ) {
cellText = feature
? translate( 'Advanced SEO tools are included' )
: translate( 'Advanced SEO tools are not included' );
: translate( 'Advanced SEO tools are {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
}
return cellText;
},
Expand Down Expand Up @@ -337,7 +351,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [
if ( isMobile ) {
cellText = feature
? translate( 'Upload videos is included' )
: translate( 'Upload videos is not included' );
: translate( 'Upload videos is {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
}
return cellText;
},
Expand All @@ -360,7 +376,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [
if ( isMobile ) {
cellText = feature
? translate( 'Collect payments is included' )
: translate( 'Collect payments is not included' );
: translate( 'Collect payments is {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
}
return cellText;
},
Expand All @@ -381,7 +399,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [
if ( isMobile ) {
cellText = feature
? translate( 'Built in social media tools are included' )
: translate( 'Built in social media tools are not included' );
: translate( 'Built in social media tools are {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
}
return cellText;
},
Expand Down Expand Up @@ -420,7 +440,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [

return feature
? translate( 'Professional Email is free for 3 months' )
: translate( 'Professional Email is not included' );
: translate( 'Professional Email is {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
},
},
{
Expand All @@ -441,7 +463,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [
if ( isMobile ) {
cellText = feature
? translate( 'Earn money from ads is included' )
: translate( 'Earn money from ads is not included' );
: translate( 'Earn money from ads is {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
}
return cellText;
},
Expand All @@ -464,7 +488,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [
if ( isMobile ) {
cellText = feature
? translate( 'SFTP, Database access is included' )
: translate( 'SFTP, Database access is not included' );
: translate( 'SFTP, Database access is {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
}
return cellText;
},
Expand All @@ -487,7 +513,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [
if ( isMobile ) {
cellText = feature
? translate( 'Automated website backups are included' )
: translate( 'Automated website backups are not included' );
: translate( 'Automated website backups are {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
}
return cellText;
},
Expand All @@ -507,7 +535,9 @@ export const planComparisonFeatures: PlanComparisonFeature[] = [
if ( isMobile ) {
cellText = feature
? translate( 'Jetpack essentials are included' )
: translate( 'Jetpack essentials are not included' );
: translate( 'Jetpack essentials are {{strong}}not{{/strong}} included', {
components: { strong: <strong /> },
} );
}
return cellText;
},
Expand Down