SignupProcessingScreen refinements (Fix to #6114) #6284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreh
added
[Status] Needs Review
| @@ -13,7 +13,7 @@ import { localize } from 'i18n-calypso'; | |||
| import Item from './item'; | |||
| import config from 'config'; | |||
|
|
|||
| const MasterbarLoggedOut = ( { title, translate } ) => ( | |||
| const MasterbarLoggedOut = ( { title, translate, showSignup = true } ) => ( | |||
There was a problem hiding this comment.
Let's add showSignup to .propTypes in L44, and although I know they achieve the same thing, we should probably either define the default in defaultProps (L48 - like title), and remove it here, or define title = '' here, and remove .defaultProps for consistency.
There was a problem hiding this comment.
Oh I missed that entirely. Adding it.
|
@coreh: Just a small edit, but otherwise is looks and works great. Thanks for the quick fix! |
|
Fixed. I also moved |
|
LGTM |
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #6114, by making it so that the
SignupFlowControlleris reset before the user clicks on the Continue button.It also adds two other improvements:
SignupProcessingScreenI18nstub is removed (We no longer need that, since the actual component landed)Sign Uplink in the masterbar is no longer displayed during signup. (So that user's can't navigate to/signupby accidentally clicking on it)Test live: https://calypso.live/?branch=fix/issue-6114