Fix tslib dependency for format-currency

[manzoorwanijk]

tslib must be a runtime dependency for all the packages that produce a CommonJS output. Otherwise there are errors as seen in #62981.

Changes proposed in this Pull Request

• Move tslib from devDependencies to dependencies for format-currency package
• Remove react from peerDependencies for it, because it doesn't need React at all.

Testing instructions

• Boot up this PR and run yarn && yarn build-packages
• Create a new project with this package.json

{
    "name": "test",
    "type": "module",
}

• Run yarn add file:<path/to/wp-calypso/packages/format-currency/> to install the local package in your new project.
• Create this index.js

import fc from '@automattic/format-currency';

const formatCurrency = fc.default || fc;

console.log( formatCurrency( 1.23, 'USD' ) );

• Do yarn install.
• Run it as node index.js
• Confirm that the command succeeds and the output is $1.23

Fixes #62981

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-31798

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-31798&env=jetpack

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[jsnajdr]

👍

[tyxla]

Thanks for this!

[tyxla]

Did you mean 1.0.1?

[manzoorwanijk]

Oh yes 🤦

[manzoorwanijk]

Should I create a PR for this or it can be fixed directly in trunk?

[tyxla]

A PR sounds good 👍 We generally never touch trunk directly here.

Happy to approve it quickly for you.

[manzoorwanijk]

Here you go
#63044

[tyxla]

Thanks @manzoorwanijk 🙌