Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup: add newsletters flow #66082

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Signup: add newsletters flow #66082

merged 4 commits into from
Jul 29, 2022

Conversation

arcangelini
Copy link
Contributor

@arcangelini arcangelini commented Jul 29, 2022

Proposed Changes

This extends the existing signup flow by adding a newsletters flow. Along with the flow I added a new function to generate the return because we will be forwarding a few other flows to stepper in the same manner.

To match the styling I added the flowName to the signup-header and removed the unnecessary div.

More details on the new flow can be found here

Testing Instructions

  1. Pull branch and run yarn start
  2. Navigate to http://calypso.localhost:3000/start/newsletters
  3. Signup for a new account using a test email address that is NOT an Automattic address (this will end in an error if you don't)
  4. Go through the entire signup and you should be redirected to http://calypso.localhost:3000/setup?flow=newsletters&siteSlug=[SITE SLUG].wordpress.com
  5. That should then put you on http://calypso.localhost:3000/setup/letsGetStarted?flow=newsletters&siteSlug=[SITE SLUG].wordpress.com

Pre-merge Checklist

@arcangelini arcangelini added [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. Stepper labels Jul 29, 2022
@arcangelini arcangelini requested a review from a team July 29, 2022 09:58
@arcangelini arcangelini self-assigned this Jul 29, 2022
@arcangelini arcangelini requested a review from a team as a code owner July 29, 2022 09:58
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 29, 2022
@github-actions
Copy link

github-actions bot commented Jul 29, 2022

@matticbot
Copy link
Contributor

matticbot commented Jul 29, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~83 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
signup                +466 B  (+0.1%)      +83 B  (+0.1%)
jetpack-connect       +438 B  (+0.0%)      +77 B  (+0.0%)
accept-invite         +438 B  (+0.1%)      +77 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~56 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-plans          +45 B  (+0.0%)      +18 B  (+0.0%)
async-load-signup-steps-emails         +45 B  (+0.0%)      +19 B  (+0.1%)
async-load-signup-steps-domains        +45 B  (+0.0%)      +19 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@alshakero alshakero self-requested a review July 29, 2022 10:43
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. Pretty neat and satisfying. We might need some customization soon. But for now, this can be shipped.

client/signup/signup-header/index.jsx Show resolved Hide resolved
@arcangelini arcangelini merged commit 8ca2d8d into trunk Jul 29, 2022
@arcangelini arcangelini deleted the add/newsletter-start-flow branch July 29, 2022 12:07
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 29, 2022
@a8ci18n
Copy link

a8ci18n commented Jul 29, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7459540

Hi @arcangelini, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Newsletters

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Aug 3, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. Stepper
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants