-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signup: add newsletters flow #66082
Signup: add newsletters flow #66082
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~83 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~56 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this. Pretty neat and satisfying. We might need some customization soon. But for now, this can be shipped.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7459540 Hi @arcangelini, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Thank you in advance! |
Translation for this Pull Request has now been finished. |
Proposed Changes
This extends the existing signup flow by adding a
newsletters
flow. Along with the flow I added a new function to generate the return because we will be forwarding a few other flows to stepper in the same manner.To match the styling I added the flowName to the
signup-header
and removed the unnecessary div.More details on the new flow can be found here
Testing Instructions
yarn start
http://calypso.localhost:3000/setup?flow=newsletters&siteSlug=[SITE SLUG].wordpress.com
http://calypso.localhost:3000/setup/letsGetStarted?flow=newsletters&siteSlug=[SITE SLUG].wordpress.com
Pre-merge Checklist