-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin Management: Implement multi-site(large screen) view for the plugin management #66219
Plugin Management: Implement multi-site(large screen) view for the plugin management #66219
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~39 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~1656 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~39 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
1ec7a89
to
d1892f5
Compare
I've noticed that when you switch between tabs, the counter for the "All" tab is updated incorrectly. Screen.Capture.on.2022-08-04.at.13-04-19.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR tests well, and I couldn't identify any regression in Calypso Blue. Excellent job, @yashwin.
I've left a few minor comments.
client/my-sites/plugins/plugin-management-v2/plugin-row-formatter/index.tsx
Outdated
Show resolved
Hide resolved
Thanks for the review, @vitozev. I have addressed all your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes! LGTM!
I noticed only one minor issue, and we can probably tackle it separately.
Can we easily trigger the search logic when we switch between tabs?
Screen.Capture.on.2022-08-04.at.15-46-55.mov
I have fixed this issue. Thanks for reporting, @vitozev 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The latest fixes look good, and no regression was found after implementation.
fb2d8aa
to
4d3cbf3
Compare
4d3cbf3
to
fb618f0
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7466929 Thank you @yashwin for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
This PR implements the large screen view(>1080px) for multi-site plugin management. The small screen view(<1080px) will be implemented in a different PR
Testing Instructions
Prerequisites
Since this change is made specifically for agencies, you must set yourself(partner) as an agency - 2c49b-pb. Make sure to switch it back to the previous type.
Instructions
git checkout add/plugin-management-multi-site-large-screen-view
andyarn start-jetpack-cloud-p
Update
text should redirect the user to the plugin details page.Pre-merge Checklist
Complete applicable items on this checklist before merging into the trunk. Inapplicable items can be left unchecked.
The PR author and reviewer are responsible for completing the checklist.
Have you tested the feature in Simple, Atomic, and self-hosted Jetpack sites?Related to 1202518759611394-as-1202698250096202, 1202518759611394-as-1202672925908038 & 1202518759611394-as-1202672925908026