-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin Management: Implement single-site(large screen) view for the plugin management #66252
Plugin Management: Implement single-site(large screen) view for the plugin management #66252
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~263 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
ace6d98
to
8e6fa9d
Compare
client/my-sites/plugins/plugin-management-v2/plugin-row-formatter/index.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic job, Yashwin.
I think we can move forward with these changes once we fix the minor alignment issue I mentioned in a comment.
fb2d8aa
to
4d3cbf3
Compare
8e6fa9d
to
75a1c15
Compare
4d3cbf3
to
fb618f0
Compare
4a25c36
to
f85df9d
Compare
Thanks for the review, @rcanepa. I have fixed the alignment issue. |
f85df9d
to
bfbc7e5
Compare
Looks great now. I think you can ! |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7468023 Thank you @yashwin for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
This PR is built on top of #66219
This PR implements the large screen view(>1080px) for single-site plugin management. The small screen view(<1080px) will be implemented in a different PR.
Testing Instructions
Prerequisites
Since this change is made specifically for agencies, you must set yourself(partner) as an agency - 2c49b-pb. Make sure to switch it back to the previous type.
Instructions
git checkout add/plugin-management-single-site-large-screen-view
andyarn start-jetpack-cloud-p
Update
should redirect the user to the plugin details page.Active
andAutoupdate
toggle buttons works as expected.Pre-merge Checklist
Complete applicable items on this checklist before merging into the trunk. Inapplicable items can be left unchecked.
The PR author and reviewer are responsible for completing the checklist.
Have you tested the feature in Simple, Atomic, and self-hosted Jetpack sites?Related to 1202518759611394-as-1202673439327762