Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Management: Implement single-site(large screen) view for the plugin management #66252

Merged
merged 4 commits into from
Aug 9, 2022

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Aug 4, 2022

Proposed Changes

This PR is built on top of #66219

This PR implements the large screen view(>1080px) for single-site plugin management. The small screen view(<1080px) will be implemented in a different PR.

Testing Instructions

Prerequisites

Since this change is made specifically for agencies, you must set yourself(partner) as an agency - 2c49b-pb. Make sure to switch it back to the previous type.

Instructions

  1. Run git checkout add/plugin-management-single-site-large-screen-view and yarn start-jetpack-cloud-p
  2. Open http://jetpack.cloud.localhost:3001/, and you'll be redirected to the /dashboard.
  3. Click on Switch Site -> Select any site -> Click on Plugins -> Verify the plugins are shown as shown below.

Screenshot 2022-08-04 at 12 31 56 PM

  1. Clicking on Update should redirect the user to the plugin details page.

Screenshot 2022-08-04 at 12 40 09 PM

  1. Verify Active and Autoupdate toggle buttons works as expected.
  2. Verify search works as expected.
  3. Click on all the tabs - All, Active, Inactive & Updates and verify the plugins are shown as per the filter and the URL is changing accordingly.
  4. Verify these changes have not affected anything in Calypso Blue.

NOTE: The more actions icon(...) is just a placeholder and will be updated later in a different PR. We are reusing <PluginActivateToggle /> and <PluginAutoupdateToggle /> components which is being used in WP.com

Pre-merge Checklist

Complete applicable items on this checklist before merging into the trunk. Inapplicable items can be left unchecked.

The PR author and reviewer are responsible for completing the checklist.

Related to 1202518759611394-as-1202673439327762

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

@yashwin yashwin self-assigned this Aug 4, 2022
@yashwin yashwin added Jetpack Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Aug 4, 2022
@yashwin yashwin requested review from a team August 4, 2022 07:13
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 4, 2022
@matticbot
Copy link
Contributor

matticbot commented Aug 4, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~263 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                              +1004 B  (+0.1%)     +263 B  (+0.1%)
jetpack-cloud-plugin-management      +1004 B  (+0.1%)     +263 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@yashwin yashwin marked this pull request as ready for review August 4, 2022 07:18
@yashwin yashwin force-pushed the add/plugin-management-single-site-large-screen-view branch from ace6d98 to 8e6fa9d Compare August 4, 2022 13:38
@rcanepa
Copy link
Contributor

rcanepa commented Aug 5, 2022

The checkboxes are not vertically aligned due to a 5px margin bottom pushing them up (I'm not 100% sure this is the reason).

image

Copy link
Contributor

@rcanepa rcanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job, Yashwin.

I think we can move forward with these changes once we fix the minor alignment issue I mentioned in a comment.

@yashwin yashwin force-pushed the add/plugin-management-multi-site-large-screen-view branch from fb2d8aa to 4d3cbf3 Compare August 8, 2022 05:53
@yashwin yashwin force-pushed the add/plugin-management-single-site-large-screen-view branch from 8e6fa9d to 75a1c15 Compare August 8, 2022 06:12
@yashwin yashwin force-pushed the add/plugin-management-multi-site-large-screen-view branch from 4d3cbf3 to fb618f0 Compare August 8, 2022 06:35
@yashwin yashwin force-pushed the add/plugin-management-single-site-large-screen-view branch 2 times, most recently from 4a25c36 to f85df9d Compare August 8, 2022 06:46
@yashwin
Copy link
Contributor Author

yashwin commented Aug 8, 2022

Thanks for the review, @rcanepa. I have fixed the alignment issue.

Base automatically changed from add/plugin-management-multi-site-large-screen-view to trunk August 8, 2022 07:07
@yashwin yashwin force-pushed the add/plugin-management-single-site-large-screen-view branch from f85df9d to bfbc7e5 Compare August 8, 2022 07:15
@rcanepa
Copy link
Contributor

rcanepa commented Aug 8, 2022

Thanks for the review, @rcanepa. I have fixed the alignment issue.

Looks great now. I think you can :shipit: !

@yashwin yashwin merged commit 68615c0 into trunk Aug 9, 2022
@yashwin yashwin deleted the add/plugin-management-single-site-large-screen-view branch August 9, 2022 05:08
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 9, 2022
@a8ci18n
Copy link

a8ci18n commented Aug 9, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7468023

Thank you @yashwin for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Aug 18, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants