Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost product: Move 'Automated critical CSS' to top of features list. #68241

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

elliottprogrammer
Copy link
Contributor

@elliottprogrammer elliottprogrammer commented Sep 25, 2022

Proposed Changes

In the pricing page product lightbox for the Boost product, this PR removes the "(Paid feature)" from the "Automated critical CSS" feature and moved the feature up to the top. Also makes it bold because this feature is the difference between the paid product and the free one. (See before & after screenshots):

Fixes: 1202796695664022-as-1203029862618675

BEFORE AFTER
Markup 2022-09-25 at 10 56 06 Markup 2022-09-25 at 10 56 50

Testing Instructions

It's assumed that you are proxied.

  • Do any one of these
    • Click on Jetpack Cloud live link below and wait for the redirect to complete, then go to /pricing
    • or boot up this PR
  • Go to the "Boost" product and click "More about Boost" to open the lightbox.
  • In the "Includes" section, verify that the "Automated critical CSS" feature has been moved to the top. Verify the "(Paid feature)" text has been removed. (See before & after screenshots above.)

Pre-merge Checklist


@elliottprogrammer elliottprogrammer added Jetpack [Feature] Pricing Feedback related to the pricing structure of WordPress.com's plans and services. labels Sep 25, 2022
@elliottprogrammer elliottprogrammer self-assigned this Sep 25, 2022
@elliottprogrammer elliottprogrammer requested a review from a team September 25, 2022 15:10
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 25, 2022
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~0 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +50 B  (+0.0%)       +0 B

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
themes                                 +50 B  (+0.0%)       -1 B  (-0.0%)
theme                                  +50 B  (+0.0%)       -1 B  (-0.0%)
stats                                  +50 B  (+0.0%)       -1 B  (-0.0%)
site-purchases                         +50 B  (+0.0%)       -1 B  (-0.0%)
signup                                 +50 B  (+0.0%)       -1 B  (-0.0%)
settings-writing                       +50 B  (+0.0%)       -1 B  (-0.0%)
settings-security                      +50 B  (+0.0%)       -1 B  (-0.0%)
settings-performance                   +50 B  (+0.0%)       -1 B  (-0.0%)
settings                               +50 B  (+0.0%)       -1 B  (-0.0%)
scan                                   +50 B  (+0.0%)       -1 B  (-0.0%)
purchases                              +50 B  (+0.0%)       -1 B  (-0.0%)
purchase-product                       +50 B  (+0.0%)       -1 B  (-0.0%)
posts-custom                           +50 B  (+0.0%)       -1 B  (-0.0%)
posts                                  +50 B  (+0.0%)       -1 B  (-0.0%)
plugins                                +50 B  (+0.0%)       -1 B  (-0.0%)
plans                                  +50 B  (+0.0%)       -1 B  (-0.0%)
people                                 +50 B  (+0.0%)       -1 B  (-0.0%)
migrate                                +50 B  (+0.0%)       -1 B  (-0.0%)
media                                  +50 B  (+0.0%)       -1 B  (-0.0%)
marketplace                            +50 B  (+0.0%)       -1 B  (-0.0%)
marketing                              +50 B  (+0.0%)       -1 B  (-0.0%)
jetpack-search                         +50 B  (+0.0%)       -1 B  (-0.0%)
jetpack-connect                        +50 B  (+0.0%)       -1 B  (-0.0%)
jetpack-cloud-settings                 +50 B  (+0.0%)       -1 B  (-0.0%)
jetpack-cloud-pricing                  +50 B  (+0.0%)       -1 B  (-0.0%)
jetpack-cloud-plugin-management        +50 B  (+0.0%)       -1 B  (-0.0%)
jetpack-cloud-partner-portal           +50 B  (+0.0%)       -1 B  (-0.0%)
jetpack-cloud-agency-dashboard         +50 B  (+0.0%)       -1 B  (-0.0%)
hosting                                +50 B  (+0.0%)       -1 B  (-0.0%)
home                                   +50 B  (+0.0%)       -1 B  (-0.0%)
help                                   +50 B  (+0.0%)       -1 B  (-0.0%)
email                                  +50 B  (+0.0%)       -1 B  (-0.0%)
earn                                   +50 B  (+0.0%)       -1 B  (-0.0%)
domains                                +50 B  (+0.0%)       -1 B  (-0.0%)
checkout                               +50 B  (+0.0%)       -1 B  (-0.0%)
backup                                 +50 B  (+0.0%)       -1 B  (-0.0%)
activity                               +50 B  (+0.0%)       -1 B  (-0.0%)
accept-invite                          +50 B  (+0.0%)       -1 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1 bytes removed 📉 [gzipped])

name                                                              parsed_size           gzip_size
async-load-masterbar-cart-masterbar-cart-wrapper                        +50 B  (+0.0%)       -1 B  (-0.0%)
async-load-design-playground                                            +50 B  (+0.0%)       -1 B  (-0.0%)
async-load-design-blocks                                                +50 B  (+0.0%)       -1 B  (-0.0%)
async-load-design                                                       +50 B  (+0.0%)       -1 B  (-0.0%)
async-load-calypso-reader-sidebar                                       +50 B  (+0.0%)       -1 B  (-0.0%)
async-load-calypso-post-editor-editor-media-modal                       +50 B  (+0.0%)       -1 B  (-0.0%)
async-load-calypso-my-sites-current-site-stale-cart-items-notice        +50 B  (+0.1%)       -1 B  (-0.0%)
async-load-calypso-my-sites-current-site-notice                         +50 B  (+0.0%)       -1 B  (-0.0%)
async-load-calypso-components-web-preview-component                     +50 B  (+0.0%)       -1 B  (-0.0%)
async-load-calypso-blocks-jitm-templates-sidebar-banner                 +50 B  (+0.1%)       -1 B  (-0.0%)
async-load-calypso-blocks-jitm-templates-notice                         +50 B  (+0.1%)       -1 B  (-0.0%)
async-load-calypso-blocks-jitm-templates-default                        +50 B  (+0.1%)       -1 B  (-0.0%)
async-load-calypso-blocks-inline-help-popover                           +50 B  (+0.0%)       -1 B  (-0.0%)
async-load-calypso-blocks-editor-checkout-modal                         +50 B  (+0.0%)       -1 B  (-0.0%)
async-load-automattic-help-center                                       +50 B  (+0.0%)       -1 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@jkguidaven jkguidaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and working as expected 💯

@elliottprogrammer elliottprogrammer merged commit 21b0489 into trunk Sep 26, 2022
@elliottprogrammer elliottprogrammer deleted the update/boost-product-includes-info branch September 26, 2022 14:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 26, 2022
@a8ci18n
Copy link

a8ci18n commented Sep 26, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7552288

Thank you @elliottprogrammer for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 6, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Pricing Feedback related to the pricing structure of WordPress.com's plans and services. Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants