New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marketplace: Add CollectionListView #68884
Conversation
9341c0c
to
1626349
Compare
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~882 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7575186 Thank you @lsl for including a screenshot in the description! This is really helpful for our translators. |
@vinimotaa Adding your feedback here to address:
@lsl had also asked here about icons. |
@vinimotaa I think I see what you're referring to. I updated the CSS to decrease the size of the compact icon to 40px, and adjusted the margin a bit to suit the smaller icon size. Please let us know if there's more you see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yoast is a bit over-represented, and we're still waiting on some translations, but otherwise, it looks good to me! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, everyone! Agree with @DustyReagan, tomorrow seems to be a good day to merge it so we'll have more translations in place and probably a replacement for Yoast in the monetization category.
- Default css for mobile - Tablet with only two blocks - Wide screen with three blocks - Small sizes with text-overflow: ellipsis
3d4c462
to
6972d4c
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7575186 Thank you @lsl for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
Testing Instructions
Fixes #68800
Fixes #67979
Fixes #67925
Fixes #67980
Fixes #67982
Fixes #68877
Related to #67987
Before
After