Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace: Add CollectionListView #68884

Merged
merged 6 commits into from Oct 12, 2022
Merged

Marketplace: Add CollectionListView #68884

merged 6 commits into from Oct 12, 2022

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Oct 11, 2022

Proposed Changes

Testing Instructions

  • Plugins screen should render the new collections sections
  • Old sections should be shrunk to 4 from 6

Fixes #68800
Fixes #67979
Fixes #67925
Fixes #67980
Fixes #67982
Fixes #68877

Related to #67987

Before
Screenshot 2022-10-11 at 17-09-50 Plugins ‹ Bussiness Simple — WordPress com

After
Screenshot 2022-10-11 at 15-29-10 Plugins ‹ Simple 123 — WordPress com

@lsl lsl requested a review from a team October 11, 2022 06:11
@lsl lsl self-assigned this Oct 11, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 11, 2022
@matticbot
Copy link
Contributor

matticbot commented Oct 11, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~882 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
plugins      +3242 B  (+0.1%)     +882 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@paulopmt1 paulopmt1 added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Oct 11, 2022
@a8ci18n
Copy link

a8ci18n commented Oct 11, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7575186

Thank you @lsl for including a screenshot in the description! This is really helpful for our translators.

@allilevine
Copy link
Member

@vinimotaa Adding your feedback here to address:

Hi @lsl, thanks for this, is this ready for a design review? Product cards seem a bit off from the design specs provided. If the team is still working on it, it's ok, otherwise, we could double-check check paddings, font sizes, thumbnail sizes, etc. Happy to help

@lsl had also asked here about icons.

@DustyReagan
Copy link
Member

Product cards seem a bit off from the design specs provided

@vinimotaa I think I see what you're referring to. I updated the CSS to decrease the size of the compact icon to 40px, and adjusted the margin a bit to suit the smaller icon size. Please let us know if there's more you see. ☺️

Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yoast is a bit over-represented, and we're still waiting on some translations, but otherwise, it looks good to me! 👍

Copy link
Contributor

@paulopmt1 paulopmt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, everyone! Agree with @DustyReagan, tomorrow seems to be a good day to merge it so we'll have more translations in place and probably a replacement for Yoast in the monetization category.

@lsl lsl merged commit ba0b00e into trunk Oct 12, 2022
@lsl lsl deleted the update/collections-view branch October 12, 2022 04:51
@github-actions github-actions bot removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 12, 2022
@a8ci18n
Copy link

a8ci18n commented Oct 12, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7575186

Thank you @lsl for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 21, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants