Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Global Styles: Update the Privacy settings upgrade notice #70643

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Dec 1, 2022

Proposed Changes

  • Update the copy of the Global Styles gating upgrade nudge in the General -> Privacy settings.
  • Also update the "Upgrade" link to automatically suggest the Premium plan when opening the Plans page.
Before After
Screenshot 2022-12-01 at 11 28 50 Screenshot 2022-12-01 at 11 28 58

Testing Instructions

  • Create a new site and apply the wpcom-limit-global-styles sticker.
  • Run these changes in a development environment (local, Calypso Live, wpcalypso).
  • Open the Site Editor, change some Global Styles and save.
  • Open Settings -> General and scroll to the Privacy section.
  • ⚠️ Ensure the upgrade notice appears and it uses the updated copy.
  • Click on "Upgrade".
  • ⚠️ Ensure it opens the plans comparison page, and the Premium plan is suggested.

Pre-merge Checklist

  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #

@Copons Copons added [Feature] Site Settings All other general site settings. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. labels Dec 1, 2022
@Copons Copons requested a review from a team December 1, 2022 11:50
@Copons Copons self-assigned this Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

@matticbot
Copy link
Contributor

matticbot commented Dec 1, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~25 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
settings        +47 B  (+0.0%)      +25 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says 👍 Similar to other nudges, it would be nice to link to what the style changes are somehow, but that's a potential future improvement.

@Copons Copons added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 1, 2022
@Copons Copons force-pushed the update/global-styles-privacy-upgrade-nudge branch from 6f76582 to c1bde1e Compare December 1, 2022 15:37
@Copons Copons merged commit 95f54c6 into trunk Dec 1, 2022
@Copons Copons deleted the update/global-styles-privacy-upgrade-nudge branch December 1, 2022 16:49
@a8ci18n
Copy link

a8ci18n commented Dec 1, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7650317

Thank you @Copons for including a screenshot in the description! This is really helpful for our translators.

1 similar comment
@a8ci18n
Copy link

a8ci18n commented Dec 11, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7650317

Thank you @Copons for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 23, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Feature] Site Settings All other general site settings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants