New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Pro Dashboard: show "Not supported on multisite" when a product is not supported on a multisite #74692
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~186 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client/jetpack-cloud/sections/agency-dashboard/sites-overview/site-status-content.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added one comment that I think will make the code easier to read. WDYT?
I have made the changes - 93fda78 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
93fda78
to
c08da2d
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7883000 Thank you @yashwin for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Closes #73406
Proposed Changes
This PR makes the following changes
-
with a tooltip showingNot supported on multisite
when the product isScan
-
with a tooltip showingNot supported on multisite
when the product isBackup
and does not have a backup subscription https://href.li/?https://wp.me/pbuNQi-1jgTesting Instructions
Testing Instructions
Prerequisites
Since these changes are made specifically for agencies, you must set yourself(partner) as an agency - 2c49b-pb. Make sure to switch it back to the previous type.
Instructions
git checkout fix/handle-unsupported-products-for-multisite
andyarn start-jetpack-cloud
-
and when hovering over, it showsNot supported on multisite
. We will show the backup as it is if it is already added - https://href.li/?https://wp.me/pbuNQi-1jg-
and when hovering over, it showsNot supported on multisite
.Pre-merge Checklist