Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the “My Sites” copy from the top left of the masterbar #89469

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Apr 12, 2024

Proposed Changes

This PR removes the “My Sites” copy from the top left of the masterbar.

before after
Screenshot 2024-04-12 at 17 00 09 Screenshot 2024-04-12 at 16 58 26

Since we've made a change to the site switcher in #87585, the “My Sites” label on the masterbar (see the before image above) may lead to confusion, as it actually redirects users to Home instead of /sites. This PR proposes to remove the copy and retain only the logo, which is already the case on the classic interface and would be consistent with Core.

p1712898028178789/1712871943.690009-slack-C06DN6QQVAQ

Testing Instructions

  • Prepare a site with Default interface
  • Go to any Calypso page (e.g., /home/<site>)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/my-sites on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~47 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
entry-stepper       -147 B  (-0.0%)      -47 B  (-0.0%)
entry-main          -147 B  (-0.0%)      -47 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@okmttdhr okmttdhr marked this pull request as ready for review April 12, 2024 08:07
@okmttdhr okmttdhr requested review from a team April 12, 2024 08:07
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 12, 2024
Copy link
Contributor

@candy02058912 candy02058912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
all sites

@okmttdhr okmttdhr merged commit 8189c33 into trunk Apr 12, 2024
21 checks passed
@okmttdhr okmttdhr deleted the update/my-sites branch April 12, 2024 08:40
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 12, 2024
@davemart-in
Copy link
Contributor

davemart-in commented Apr 12, 2024

@okmttdhr when I go to /wp-admin/edit.php for a simple site, the "My Sites" text shows up again.

Looks like this is because I have classic view toggled on for that page via the "View" option in the top right corner. If I toggle it to the default view, "My Sites" goes away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants