-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the “My Sites” copy from the top left of the masterbar #89469
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~47 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@okmttdhr when I go to /wp-admin/edit.php for a simple site, the "My Sites" text shows up again. Looks like this is because I have classic view toggled on for that page via the "View" option in the top right corner. If I toggle it to the default view, "My Sites" goes away. |
Proposed Changes
This PR removes the “My Sites” copy from the top left of the masterbar.
Since we've made a change to the site switcher in #87585, the “My Sites” label on the masterbar (see the before image above) may lead to confusion, as it actually redirects users to
Home
instead of/sites
. This PR proposes to remove the copy and retain only the logo, which is already the case on the classic interface and would be consistent with Core.p1712898028178789/1712871943.690009-slack-C06DN6QQVAQ
Testing Instructions
/home/<site>
)Pre-merge Checklist