-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav Redesign: Move search and notifications to footer #90429
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~76 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~81 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
…search-notifications-position
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better in my opinion and works well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better in my opinion and works well
I agree! 🚢 it!
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
…search-notifications-position
Fixes https://github.com/Automattic/dotcom-forge/issues/6966
Proposed Changes
Moves the search and notifications buttons to the footer of the new sidebar so the Sites, Domains, and Reader links are kept in the same position when the sidebar is expanded/collapsed.
The sizing/spacing of the footer has been slightly adjusted as well to ensure that all items are correctly aligned.
Before
After
I also took the opportunity to refine the position of the tooltips so they look more polished.
Before
Screen.Recording.2024-05-08.at.12.24.37.mov
After
Screen.Recording.2024-05-08.at.12.24.59.mov
Testing Instructions
/sites