-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply rules/jsx-boolean-value
eslint rule
#90499
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
try limiting eslint to 1gb
revert, useless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this! 🚀
Perhaps it makes sense to add this commit to .git-blame-ignore-revs
. Will need to be done separately, after merging this one.
Proposed Changes
It applies https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-boolean-value.md eslint rule.
Not sure why, but running
npm run lint:js -- --fix --rule 'react/jsx-boolean-value: error'
fixed some more issues, not only related to this particular rule. I guess Prettier did this on commit.Link to the discussion: p1715262768075189-slack-C02DQP0FP
Testing Instructions
Code review is enough.
Pre-merge Checklist