Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply rules/jsx-boolean-value eslint rule #90499

Merged
merged 11 commits into from
May 15, 2024
Merged

Conversation

pkuliga
Copy link
Contributor

@pkuliga pkuliga commented May 9, 2024

Proposed Changes

It applies https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-boolean-value.md eslint rule.

Not sure why, but running npm run lint:js -- --fix --rule 'react/jsx-boolean-value: error' fixed some more issues, not only related to this particular rule. I guess Prettier did this on commit.

Link to the discussion: p1715262768075189-slack-C02DQP0FP

Testing Instructions

Code review is enough.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented May 9, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • editing-toolkit
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/boolean-value-fix on your sandbox.

@pkuliga pkuliga marked this pull request as ready for review May 15, 2024 13:09
@pkuliga pkuliga requested review from a team as code owners May 15, 2024 13:09
@pkuliga pkuliga requested a review from ddc22 May 15, 2024 13:09
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 15, 2024
@pkuliga pkuliga requested review from stephanethomas and removed request for a team May 15, 2024 13:09
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this! 🚀

Perhaps it makes sense to add this commit to .git-blame-ignore-revs. Will need to be done separately, after merging this one.

@pkuliga pkuliga merged commit b359eb4 into trunk May 15, 2024
21 checks passed
@pkuliga pkuliga deleted the update/boolean-value-fix branch May 15, 2024 13:13
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants