Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled Updates: Remove table row background highlight #91064

Merged
merged 1 commit into from
May 23, 2024

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented May 23, 2024

Related to p1716475758053739/1715969434.134879-slack-C01A60HCGUA

Proposed Changes

  • Removes table row background highlight

Testing Instructions

  • Go to /plugins/scheduled-updates
  • Expand a row
  • Check if there is a white background instead of a gray
Before After
Screenshot 2024-05-23 at 18 17 29 Screenshot 2024-05-23 at 18 17 38

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bogiii bogiii requested a review from a team May 23, 2024 16:18
@bogiii bogiii self-assigned this May 23, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 23, 2024
@bogiii bogiii changed the title Scheduled Updates: Remove row background highlight Scheduled Updates: Remove table row background highlight May 23, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/multisite-scheduled-updates-13 on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@lucasmendes-design
Copy link

LGTM. Thanks again @bogiii 😃💯

@bogiii bogiii merged commit 0ce4cca into trunk May 23, 2024
14 of 15 checks passed
@bogiii bogiii deleted the update/multisite-scheduled-updates-13 branch May 23, 2024 18:44
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants