Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove contact form for chat #91120

Merged
merged 1 commit into from
May 24, 2024
Merged

Remove contact form for chat #91120

merged 1 commit into from
May 24, 2024

Conversation

alshakero
Copy link
Member

Proposed Changes

This removes the contact form step for chat users.

Why are these changes being made?

pdDR7T-1vN-p2#comment-1998

Testing Instructions

  1. Check this branch locally.
  2. Change this check to false.
  3. Open the Help Center.
  4. Ask Wapuu for a human.
  5. Click the support button.
  6. It should open the chat widget.

Regression testing

  1. Clear the change you made to the check mentioned above.
  2. Open the Help Center.
  3. Ask Wapuu for a human.
  4. Click the email option.
  5. You should see the contact form.

@alshakero alshakero requested a review from a team May 24, 2024 14:04
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 24, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~15 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
async-load-automattic-help-center       +181 B  (+0.0%)      +15 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • editing-toolkit

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/contant-form-for-chat on your sandbox.

Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It behaves exactly like in the testing steps 👍

@alshakero alshakero merged commit 56181b4 into trunk May 24, 2024
12 of 14 checks passed
@alshakero alshakero deleted the remove/contant-form-for-chat branch May 24, 2024 14:17
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants