Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: fix referrals purchases count #91654

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

andrii-lysenko
Copy link
Contributor

Resolves https://github.com/Automattic/jetpack-genesis/issues/375

Proposed Changes

Fix issue with wrong Purchases number in referrals overview. We were overwritting original. Also, refactored a function a bit.

Why are these changes being made?

Testing Instructions

  • Using live link below make several referrals
  • Navigate to /referrals/dashboard and check the number of referrals
  • Leave the page and enter again, check that behavior is correct.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@andrii-lysenko andrii-lysenko added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. A4A labels Jun 10, 2024
@andrii-lysenko andrii-lysenko requested a review from a team June 10, 2024 22:43
@andrii-lysenko andrii-lysenko self-assigned this Jun 10, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~6 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
a8c-for-agencies-referrals        +22 B  (+0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@yashwin yashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. LGTM.

I'm merging this one 💯

@yashwin yashwin merged commit 95200db into trunk Jun 11, 2024
14 checks passed
@yashwin yashwin deleted the a4a/fix-referrals-marketplace-numbers branch June 11, 2024 03:57
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants