Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move importer types into clientlib importer #91690

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

markbiek
Copy link
Contributor

This is the last piece of moving all of the importer definitions into a single area

Fixes #90635

Proposed Changes

In #91609, we refactored all of places that define different importers into a single area. As a final step, this moves importer-related types into the same area.

Why are these changes being made?

Previously, there were multiple lists of importers in different places. Having a single source of truth will make it easier to keep track of things and make updates.

Testing Instructions

Since this is just moving import definitions around, visual inspections and verifying all of the CI actions pass should be sufficient.

However, you could follow the testing instructions in #91609 as an optional, additional check.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@markbiek markbiek self-assigned this Jun 11, 2024
@markbiek markbiek requested a review from a team as a code owner June 11, 2024 18:19
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 11, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

This is the last piece of moving all of the importer definitions into a single area
@markbiek markbiek force-pushed the 90635-update/available-importers-refactor branch from 2692627 to ecdd5d3 Compare June 11, 2024 19:06
Copy link
Contributor

@nelsonec87 nelsonec87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markbiek markbiek merged commit 27fa228 into trunk Jun 12, 2024
11 checks passed
@markbiek markbiek deleted the 90635-update/available-importers-refactor branch June 12, 2024 12:57
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importers: Consolidate list of supported/available importers
3 participants