Refactor list of site importers into a single location

[markbiek]

Related to #90635

Proposed Changes

This updates the getConfig function in client/lib/importer/importer-config.tsx to be the single source of information about available site importers.

It also updates the ListStep and getFinalImporterUrl helper so they pull the data they need from the updated getConfig function.

This is done with two new functions:

• getImporterEngines which returns a list of the importer engine slugs.
• getImportersAsImporterOption which returns either the primary or secondary importers in the ImporterOption format.

Why are these changes being made?

Previously, there were multiple lists of importers in different places. Having a single source of truth will make it easier to keep track of things and make updates.

Testing Instructions

There are tests for the two new functions for retrieving importer details:

yarn test-client client/lib/importer/test/importer-config.tsx

To test the actual UI, you can use either calypso.live or check out this branch and run it locally.

Then there are two ways to get to the importer list.

1. Visit /sites, click the ^ next to "Add new site" and click "Import an existing site".
2. Or you can go through /start and select the "Import existing content or website" Goal.

You'll eventually arrive at the "Let's find your site" step

Click "pick your current platform from a list". You should be taken to "Import content from another platform".

From here, verify that the options are displaying correctly.

Then try clicking a few of the importers in the top section and in the "Other platforms" dropdown.

You should be taken to the correct import page for the source slte you selected.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-110553

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-110553&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-110553&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~32 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions          -84 B  (-0.0%)      -41 B  (-0.0%)
entry-stepper                -84 B  (-0.0%)      -32 B  (-0.0%)
entry-main                   -84 B  (-0.0%)      -39 B  (-0.0%)
entry-login                  -84 B  (-0.0%)      -41 B  (-0.0%)
entry-domains-landing        -84 B  (-0.0%)      -41 B  (-0.0%)
entry-browsehappy            -84 B  (-0.0%)      -41 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~493 bytes removed 📉 [gzipped])

name                     parsed_size           gzip_size
import-hosted-site-flow      +1576 B  (+0.2%)    +1230 B  (+0.5%)
import                       +1239 B  (+0.2%)    +1174 B  (+0.7%)
import-flow                  +1131 B  (+0.0%)     +368 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[markbiek]

Noting that I don't think those test failures are related to this PR. I tried running them locally against trunk and they failed the same way.

I was seeing similar behavior last week with different tests.

And now all the tests pass 🤷

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug 90635-update/available-importers-refactor on your sandbox.

[sixhours]

For some reason I'm seeing Wix in the primary importers list locally, but not on calypso.live. 🤔 Is there a reason for that, do you know?

[markbiek]

For some reason I'm seeing Wix in the primary importers list locally, but not on calypso.live. 🤔 Is there a reason for that, do you know?

@sixhours Hmm. I'm not seeing it locally or calypso.live.

Which path did you take? Was it /start or the import menu from /sites?

[sixhours]

This is working for me!

[sixhours]

For some reason I'm seeing Wix in the primary importers list locally, but not on calypso.live. 🤔 Is there a reason for that, do you know?

@sixhours Hmm. I'm not seeing it locally or calypso.live.

Which path did you take? Was it /start or the import menu from /sites?

Nevermind, I don't see it there now. 🙃