Expand plugins sidebar menu when browsing categories #92003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~171 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
matticbot
added
the
[Status] Needs Review
xavier-lc
force-pushed
the
fix/expand-plugins-sidebar-when-navigating-categories
branch
from
d6ef3fd
to
bf8ea8f
Compare
xavier-lc
deleted the
fix/expand-plugins-sidebar-when-navigating-categories
branch
github-actions
bot
removed
the
[Status] Needs Review
|
Hi folks, we don't need the breadcrump anymore. 
Instead of the breadcrumb "Plugins > Search Engine Optimization", we can keep the copy "Plugins Marketplace" cc: @xavier-lc |
7 tasks
What should we do on mobile? Currently, below 960px the breadcrumb becomes a back button:
|
|
We can use the same patterns as the themes page or something similar. These two pages are very alike and should function almost in the same way. Themes: Plugins:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/Automattic/dotcom-forge/issues/7491
Proposed Changes
/plugins/{siteId}and clicks on a category, the plugins sidebar menu is collapsed instead of staying expanded and highlightingMarketplace. This PR fixes that.Why are these changes being made?
Testing Instructions
/plugins/{siteId}MarketplacePre-merge Checklist