Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color scheme: Fix Classic Bright menu & submenu colors #92005

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

lupus2k
Copy link
Contributor

@lupus2k lupus2k commented Jun 20, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/7825

Proposed Changes

Update sidebar colors of Classic Bright color scheme when selected Classic Interface.
Also fixes All sites icon size (follow up Automattic/jetpack#37832)

wp-admin Calypso Before Calypso After
image image image

Why are these changes being made?

Colors of menu submenu doesn't match with wp-admin

Testing Instructions

  • Using a classic interface site
  • Choose the Classic Bright color scheme in /wp-admin/profile.php
  • Check the colors of the menu & submenu in wp-admin and Calypso
  • Also compare the All Sites icon size in wp-admin and Calypso

@lupus2k lupus2k self-assigned this Jun 20, 2024
@lupus2k lupus2k requested a review from a team June 20, 2024 18:35
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 20, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Jun 20, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • editing-toolkit
  • happy-blocks
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/classic-bright-redesign-styles on your sandbox.

@lupus2k lupus2k force-pushed the fix/classic-bright-redesign-styles branch 2 times, most recently from 3b8edba to 79f0a5a Compare June 20, 2024 21:54
@lupus2k lupus2k force-pushed the fix/classic-bright-redesign-styles branch from 79f0a5a to 4c8ee12 Compare June 20, 2024 22:23
@lupus2k lupus2k merged commit 48d0462 into trunk Jun 20, 2024
10 checks passed
@lupus2k lupus2k deleted the fix/classic-bright-redesign-styles branch June 20, 2024 22:59
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants