Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update All Sites icon size for Simple Classic #37832

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

lupus2k
Copy link
Contributor

@lupus2k lupus2k commented Jun 12, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/7483

Proposed changes:

Update the All Sites icon size on Classic Interface.

Before After
sites-icon-before sites-icon-after

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

No

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Go to 'wp-admin' with a Classic Interface site (you can switch it in Settings)
  • Check the All Sites icon size

@lupus2k lupus2k self-assigned this Jun 12, 2024
Copy link
Contributor

github-actions bot commented Jun 12, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/all-sites-icon-size branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/all-sites-icon-size
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jun 12, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 12, 2024
@lupus2k lupus2k requested review from a team June 12, 2024 20:32
@lupus2k lupus2k force-pushed the update/all-sites-icon-size branch from d22e9fc to 31afd40 Compare June 13, 2024 15:02
@lucasmendes-design
Copy link

lucasmendes-design commented Jun 14, 2024

Hi there, I may be doing something wrong but the icons are different. What is the link I should visit? Horizon?

image image

@lupus2k
Copy link
Contributor Author

lupus2k commented Jun 14, 2024

Hi there, I may be doing something wrong but the icons are different. What is the link I should visit? Horizon?

image image

Sorry, You have to run bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/all-sites-icon-size in your sandox

Copy link
Contributor

@miksansegundo miksansegundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
Screenshot 2567-06-14 at 20 54 04 Screenshot 2567-06-14 at 20 55 39

It's easier to see the change on this recording:

Screen.Recording.2567-06-14.at.20.56.27.mov

@lupus2k lupus2k enabled auto-merge (squash) June 14, 2024 14:15
@miksansegundo
Copy link
Contributor

@lucasmendes-design let us know if this new size looks good to you 🙂 on the recording. I believe you don't have a sandbox for testing it.

@lupus2k lupus2k disabled auto-merge June 14, 2024 14:15
@lucasmendes-design
Copy link

let us know if this new size looks good to you 🙂 on the recording. I believe you don't have a sandbox for testing it.

Yes, I haven't. Thanks for the recording :)

LGTM 🫶🏽

@lupus2k lupus2k merged commit 37cb6fd into trunk Jun 14, 2024
54 checks passed
@lupus2k lupus2k deleted the update/all-sites-icon-size branch June 14, 2024 14:22
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants