-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Previews | Add Threads preview #92056
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~4 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~4170 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~4183 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job this works well!
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/15343302 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @manzoorwanijk for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
social-previews
packageWhy are these changes being made?
Testing Instructions
public-api.wordpress.com
to your sandbox/posts/:site
Pre-merge Checklist
When there is NO Threads connection but an image
![Screenshot 2024-06-24 at 3 36 04 PM](https://private-user-images.githubusercontent.com/18226415/342299681-70b234b9-0d89-402d-92bd-34872f08dcd9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNDMyMzIsIm5iZiI6MTcyNjE0MjkzMiwicGF0aCI6Ii8xODIyNjQxNS8zNDIyOTk2ODEtNzBiMjM0YjktMGQ4OS00MDJkLTkyYmQtMzQ4NzJmMDhkY2Q5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDEyMDg1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFiY2FiOWJkNmJhNjEzNDI1YzY2NTNhMjAwNDRmMWE0NWJmNWE2YWNiNzI1ZGZiZmRiMjg3ZWJmODllZGE1OWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.-kXkCUwGC_12h2fJSM14w89JbE9e2fe2ziLEUnfm2GY)
When there is NO Threads connection and No image
![Screenshot 2024-06-24 at 3 36 55 PM](https://private-user-images.githubusercontent.com/18226415/342299707-06c5958d-e38c-4c01-8a0d-00559b787fbf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNDMyMzIsIm5iZiI6MTcyNjE0MjkzMiwicGF0aCI6Ii8xODIyNjQxNS8zNDIyOTk3MDctMDZjNTk1OGQtZTM4Yy00YzAxLThhMGQtMDA1NTliNzg3ZmJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDEyMDg1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZjZGQxMzE4Nzg1YjIzYjk0YmQwODA4NjVhMGYxMTM3NmZkMTczMDdkZjFmNDBkZGUxZmU1ZGUxMmZlMDA4ZmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rswa_OC9DoIsky-AT35I2WsOP28yUbtc07L_6Qdeb2U)
When there IS a Threads connection but and also an image
![Screenshot 2024-06-24 at 3 39 10 PM](https://private-user-images.githubusercontent.com/18226415/342299709-20553f35-2a03-4e7d-a2a2-f0555c626da2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNDMyMzIsIm5iZiI6MTcyNjE0MjkzMiwicGF0aCI6Ii8xODIyNjQxNS8zNDIyOTk3MDktMjA1NTNmMzUtMmEwMy00ZTdkLWEyYTItZjA1NTVjNjI2ZGEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDEyMDg1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNkNWFlZTYwZDM0N2E3MmI2NjRiNzE1NWNmMGE3ZmU4ZTlkOTU5MzI4YzdhZWRkZGYxMWQzYWI2M2MzNmMzNGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.dkNhbnI4ORDzEU0D7gAJqky__Q4xr-tBm6NQli9T54k)
When there IS a Threads connection but NO image
![Screenshot 2024-06-24 at 3 40 30 PM](https://private-user-images.githubusercontent.com/18226415/342299732-e789e85b-63aa-4761-bb44-ed1eea4de82f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNDMyMzIsIm5iZiI6MTcyNjE0MjkzMiwicGF0aCI6Ii8xODIyNjQxNS8zNDIyOTk3MzItZTc4OWU4NWItNjNhYS00NzYxLWJiNDQtZWQxZWVhNGRlODJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDEyMDg1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcxZWFlYWQzYTJmMzY5NDhjNDM2OWQyY2M3ZmUxM2M0MjE2YzM2NTlkMDRhOGVjOTkyZGI0NjE2ODdlZmY4MzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.NElZhT-KcliuDFVeAlSUEsT0mx3Dn-c4wBj1eXr9Ta0)
When custom media is added to the post with "Share as social post" enabled
![Screenshot 2024-06-24 at 3 46 02 PM](https://private-user-images.githubusercontent.com/18226415/342299739-71904508-c167-46a0-8b66-c791486472ad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNDMyMzIsIm5iZiI6MTcyNjE0MjkzMiwicGF0aCI6Ii8xODIyNjQxNS8zNDIyOTk3MzktNzE5MDQ1MDgtYzE2Ny00NmEwLThiNjYtYzc5MTQ4NjQ3MmFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDEyMDg1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU1ZjUxMWU0OTQwYWVjMmUxMzkzNTY3MThiNjVjMjNjMTI1NDhmYWQwYmNiMWNmMTJjOTgzYWE5NzZlMzQ0ODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sNzRmCPQFH-0VNRQFv3c3_OmNjumQ3wnFPiNCcTJie4)