Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Previews | Add Threads preview #92056

Merged
merged 7 commits into from
Jun 25, 2024

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Jun 24, 2024

Proposed Changes

  • Add Threads preview to social-previews package
  • Add Threads preview to post share preview

Why are these changes being made?

  • We are adding Threads support to Jetpack Social and we want to display post preview for Threads.

Testing Instructions

  • Sandbox D152810-code and follow the instructions given there
  • Point public-api.wordpress.com to your sandbox
  • Goto /posts/:site
  • For any post that you want to check preview for, click on options (3 dots)
  • Click on Share and then click on Preview
  • Confirm that you see the Threads tab
  • Select Threads tab
  • Confirm that the preview works as expected in different scenarios
  • Please also test this in combination with Social: Add Threads to social previews jetpack#38003

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

When there is NO Threads connection but an image
Screenshot 2024-06-24 at 3 36 04 PM

When there is NO Threads connection and No image
Screenshot 2024-06-24 at 3 36 55 PM

When there IS a Threads connection but and also an image
Screenshot 2024-06-24 at 3 39 10 PM

When there IS a Threads connection but NO image
Screenshot 2024-06-24 at 3 40 30 PM

When custom media is added to the post with "Share as social post" enabled
Screenshot 2024-06-24 at 3 46 02 PM

@manzoorwanijk manzoorwanijk added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 24, 2024
@manzoorwanijk manzoorwanijk self-assigned this Jun 24, 2024
@manzoorwanijk manzoorwanijk requested a review from a team June 24, 2024 10:25
@matticbot
Copy link
Contributor

matticbot commented Jun 24, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~4 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +42 B  (+0.0%)       +4 B  (+0.0%)
entry-main           +42 B  (+0.0%)       +4 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~4170 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
posts-custom             +11720 B  (+1.6%)    +4170 B  (+1.9%)
posts                    +11720 B  (+1.6%)    +4170 B  (+1.8%)
write-flow                 +205 B  (+0.0%)      +66 B  (+0.0%)
videopress-flow            +205 B  (+0.0%)      +66 B  (+0.0%)
link-in-bio-tld-flow       +205 B  (+0.0%)      +66 B  (+0.0%)
build-flow                 +205 B  (+0.0%)      +66 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~4183 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-design-blocks                                +11720 B  (+0.5%)    +4170 B  (+0.7%)
async-load-calypso-components-web-preview-component       +205 B  (+0.0%)      +66 B  (+0.0%)
async-load-design-playground                               +44 B  (+0.0%)      +13 B  (+0.0%)
async-load-design                                          +44 B  (+0.0%)      +13 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Jun 24, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • editing-toolkit
  • happy-blocks
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/social-previews/threads-preview on your sandbox.

Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job this works well!

@manzoorwanijk manzoorwanijk merged commit 12d5a46 into trunk Jun 25, 2024
12 checks passed
@manzoorwanijk manzoorwanijk deleted the add/social-previews/threads-preview branch June 25, 2024 11:04
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 25, 2024
@a8ci18n
Copy link

a8ci18n commented Jun 25, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/15343302

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @manzoorwanijk for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 30, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants