Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Add a global contact support widget. #92060

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

jkguidaven
Copy link
Contributor

We currently have a few components that trigger a contact support form. The current process involves redirecting users to the Overview page to render the form, as this is the only page where this component exists. This negatively impacts user experience as it forces users to move to a different page.

This pull request introduces a global contact support form that is located in the sidebar and can be triggered through a hash fragment. Components that rely on the form will only need to update the URL.

Screenshot 2024-06-24 at 10 56 19 PM

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/644

Proposed Changes

  • This pull request introduces a ContactSupportWidget component that encapsulates the UserFeedbackForm component with the required hooks to monitor changes in the URL hash fragment, which will act as the display flag. The widget will be placed in the Sidebar component since it is a common component present on all pages. This will enable triggering the form display by simply updating the URL with the contact support hash fragment anywhere in the A4A platform.

Testing Instructions

  • Go to the /overview page.
  • Confirm that when clicking the Contact us button in the Migration offer card or Contact sales and support button in the aside section triggers the Contact support display.
  • Confirm that the sidebar's contact sales button or the User profile down contact support button triggers the Contact support form display.
  • Go to the /marketplace/hosting page.
  • Click the Contact Us support from the Migration offer banner.
  • Confirm that it triggers the Contact support form.
  • Confirm that you did not redirect to the overview page.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven requested review from rcanepa and a team June 24, 2024 14:57
@jkguidaven jkguidaven self-assigned this Jun 24, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 24, 2024
@jkguidaven jkguidaven marked this pull request as ready for review June 24, 2024 14:57
@matticbot
Copy link
Contributor

matticbot commented Jun 24, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~192 bytes removed 📉 [gzipped])

name                                parsed_size           gzip_size
a8c-for-agencies-referrals              -1214 B  (-0.2%)     -202 B  (-0.1%)
a8c-for-agencies-marketplace            -1214 B  (-0.2%)     -171 B  (-0.1%)
a8c-for-agencies-sites                  -1119 B  (-0.1%)     -176 B  (-0.0%)
a8c-for-agencies-settings               -1119 B  (-0.7%)     -176 B  (-0.3%)
a8c-for-agencies-purchases              -1119 B  (-0.2%)     -176 B  (-0.1%)
a8c-for-agencies-plugins                -1119 B  (-0.8%)     -176 B  (-0.4%)
a8c-for-agencies-partner-directory      -1119 B  (-0.3%)     -176 B  (-0.1%)
a8c-for-agencies-migrations             -1119 B  (-0.6%)     -176 B  (-0.3%)
a8c-for-agencies-client                 -1119 B  (-0.1%)     -176 B  (-0.1%)
a8c-for-agencies-overview                -987 B  (-0.4%)     -171 B  (-0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jkguidaven jkguidaven force-pushed the add/a4a/global-contact-support-widget branch 2 times, most recently from 262a3c5 to dec0b52 Compare June 25, 2024 08:10
@jkguidaven jkguidaven force-pushed the add/a4a/global-contact-support-widget branch from dec0b52 to 8434634 Compare July 2, 2024 13:20
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a/global-contact-support-widget on your sandbox.

@jkguidaven jkguidaven force-pushed the add/a4a/global-contact-support-widget branch from 8434634 to 5480e70 Compare July 2, 2024 14:27
Copy link
Contributor

@andrii-lysenko andrii-lysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!

…t changes which triggers contact support form.
@jkguidaven jkguidaven force-pushed the add/a4a/global-contact-support-widget branch from 5480e70 to a2e649c Compare July 3, 2024 04:57
@jkguidaven jkguidaven merged commit ea74ab8 into trunk Jul 3, 2024
11 checks passed
@jkguidaven jkguidaven deleted the add/a4a/global-contact-support-widget branch July 3, 2024 05:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants